images are inline (check message) ? Which version (nightly) ?

Hello,

the version is 5.8.4 as written, no nightly build. The files are mainly the attached images from footer of an email (see 0005490 for our long lasting ticket) which annoying from HTML mails. Before one of the last emails they where attached in any reply and we could remove them manually not to sent them back or forward. Since last installed version they where attached as before but without any chance to delete them.

Steps to reproduce:
1) Recieve an HTML email with embedded logos or graphics
2) Have "always compose TEXT emails" as preference in your configuration
3) Push reply or reply to all
4) You will see an plain text email WITHOUT any attachements
5) Sent email
6) Reciever will get plain text email WITH attachements

If the images are in the html, there are not in attachments. There are encoded base64 img src in the html code.
I cannot reproduce your case on demo.sogo.nu. Can you provide eml ?

Sebastien

This case occurs not only with images, but as you can see in the picture, with other files exactly the same (.exe, .dll, .accdb, .zip, .js, .pub, .bmp). If you try to reply to the mail or forward it, the data is not visible and you cannot delete it. But they will be forwarded as well.

here is the eml: https://pastebin.com/EXiB0BYc

Hello Sébastien,

some news to added to support you in finding the error and maybe to fix it: BEFORE you save the draft you CANNOT see the attachments. AFTER saving, CLOSING and REOPENING the draft you'll see the attachments and can the delete them. As this is a very hard workaround we would favour if this clould be fixed soon. Thank you very much!

The Bahnkonzept team from Dresden/Germany

Hello Sébastien,

yes, it could be that you cannot reproduce on https://demo.sogo.nu/ as there all account where configured for composing messages in HTML. This error occurs when having an account configured composing messages in Plain text and replying to an HTML email with inline images or attachements only.

To make it reproduceable for you please sent a test email from ''sogo1'' (configured for HTML messages) with inline attachement to ''sogo3'' (please crosscheck, that ''sogo3'' is configured to plain text before!). Please reply to the test email. BEFORE you save the draft you CANNOT see the attachments. AFTER saving, CLOSING and REOPENING the draft you'll see the attachments and can the delete them. As this is a very hard workaround we would favour if this clould be fixed soon. Thank you very much!

The Bahnkonzept team from Dresden/Germany

We have the same problem, but after updating to 5.9.1 it only occurs when replying. Can this be confirmed by bahnkonzept and also fixed for replying by sebastien? Is it related to 0005888?

Dear rof, we can confirm that this issue is occuring when replying. For composing messages like the already fixed error in 0005888 we cannot state as we're using only plain text messages in our company.

We would be gratefully if this error may be fixed soon as it cause misunderstandings at the receiver side when replying.

Thank you very much!

The Bahnkonzept team from Dresden/Germany

Hi there,

This is not in our todo list.
If you need the fix in a faster way, you can sponsor the fix or subscribe to premium support.

Sebastien

Hello Sebastian,

We would normally thank you politely for dealing with our comments and requests. In this case, we are sure you will understand if we do not refrain from doing so.

We have really considered sponsoring the development of SoGo or buying premium support as we believe in the potential of SoGo and want to support open and free software.

We would be happy to do this for extensive further developments such as 0005843, 0005471 or 0005704 (unfortunately your conditions for this on https://www.sogo.nu/commercial.html are not particularly clear), but for a very clear bugfix (which was also added in one of the last releases!) we find this answer very surprising.

In the hope that Alinto will publish a clarification here again, we wish you a peaceful Christmas season.

The Bahnkonzept team from Dresden/Germany

Hi !

We prioritize premium support. This does not means the issue will never be fixed, but not in a near scope as we have no time for now.
My previous message means : If you need to fix this issue in shorter delays, you can subscribe commercial support, or fix the issue in the Github page with a pull request.
Of course we can propose sponsoring as described here : https://www.sogo.nu/commercial.html

Sponsored developments:
Based on Product Committee approval, financed specific developments can be prioritized and integrated in the roadmap

If you want to do sponsoring, you can use the same form in the commercial page ;)

Hope this (partially) answers your request

Sebastien

Hi there,

I have tested the issue, and can reproduce it.
Summary steps :

• SOGo messaging configure in text mode
• Reply to a message with an inline message inside
• Save draft and reopen it ... the inline image appears in attachement

As I understand you would like to get the possibility to remove the image without saving and reopening the draft (which makes sense).

[Code example for this]

diff --git i/UI/MailerUI/UIxMailEditor.m w/UI/MailerUI/UIxMailEditor.m
index 4464ab403..72d9be4d6 100644
--- i/UI/MailerUI/UIxMailEditor.m
+++ w/UI/MailerUI/UIxMailEditor.m
@@ -669,7 +669,7 @@ - (NSArray *) attachmentAttrs
   if (!attachmentAttrs || ![co imap4URL])
   {
       [co fetchInfo];
-      if ((![co inReplyTo] || currentAttachment) && [co IMAP4ID] > -1)
+      if (((![co inReplyTo]) || currentAttachment || ![co isHTML]) && [co IMAP4ID] > -1)
         {
           // When currentAttachment is defined, it means we just attached a new file to the mail
           mail = [[[SOGoMailObject alloc] initWithImap4URL: [co imap4URL] inContainer: [co container]] autorelease];
diff --git i/UI/WebServerResources/angular-material w/UI/WebServerResources/angular-material
--- i/UI/WebServerResources/angular-material
+++ w/UI/WebServerResources/angular-material

My suggestion would be to remove all inline images when replying in text mode (this is the Thunderbird's behavior)

Sebastien

Hello Sebastian,

thank you for your answer and the proposal.
We agree to your suggestion to remove all inline images when replying in text mode, as they are not longer linked to the text nor shown.
If this is will cause to much effort we would get the possibility to remove the image without saving and reopening the draft.

If you would provide a nightly build we can test is together with the latest changes from 0005490.

Thank you very much!

The Bahnkonzept team from Dresden/Germany

Hi,

Can you have a try with the nightly sogo-5.9.1.20240123-1 ?

Commit : https://github.com/Alinto/sogo/commit/0d0eda26984e825c8af82528c749238678baf159

Sebastien

Hello,

Thank you very much for implementing, we'll try on Wednesday (2024-01-24) and let you know the results.

The Bahnkonzept team from Dresden/Germany

Hello,

we tried with the nightly ''sogo-5.9.1.20240123-1'' and it worked as expected when replying to an HTML-mail in text mode. But if you forward an HTML-mail in text mode the original inline images will be still attached.

So the issue can be considered as solved for replying to an mail only. It would be great, if you could implement the same behaviour (''remove all inline images when replying in text mode'') for forwarding emails.

Thank you very much.

The Bahnkonzept team from Dresden/Germany

Hello,

without making pressure to the SoGo team: Can you tell a estimate time when could have implemented the same behaviour (''remove all inline images when replying in text mode'') for forwarding emails now?

Background: If this feature can be implemented soon, we would like to test the next nightly and make it productive after some tests. If it took longer, we'll stick to nightly ''sogo-5.9.1.20240123-1'' as it worked as expected for most cases.

Thanks a lot.

The Bahnkonzept team from Dresden/Germany