View Issue Details

IDProjectCategoryView StatusLast Update
0005490SOGoWeb Mailpublic2024-05-22 09:10
Reporterbahnkonzept Assigned Tosebastien  
PrioritynormalSeverityfeatureReproducibilityalways
Status resolvedResolutionreopened 
Product Version5.5.0 
Fixed in Version5.9.1 
Summary0005490: Embedded logos in emails (company, Twitter and Facebook links, etc.) are shown as downloadable .png files
Description

Normally, the attached files (word, PDF, excel) are shown at the bottom of an email. Nowadays people sometimes embed logos in their emails as well (not as attachments).

When an email is received, the company logos along with any Twitter/Facebook/etc links which include a picture which are embedded in the email are shown as downloadable .png files. In some emails, this can create multiple downloadable files (see screenshot) and this makes it difficult to find the actual attachment that was sent in the email.

It would be a great improvement for the user experience if you could make it so that the embedded logos/pictures are not shown next to the real attachments (word, excel, PDF). Our wish is that the embedded pictures should not be shown as attachments (should not even be visible). From our view, configurability is not needed by the user in this case.

For example: in the screenshot, only the two PDFs should be shown (without all other .png files)

As always, thank you very much for taking a look at this issue!

TagsNo tags attached.

Activities

bahnkonzept

bahnkonzept

2022-03-10 15:38

reporter  

bahnkonzept

bahnkonzept

2022-09-09 16:05

reporter   ~0016214

Dear Sogo-Team,
may we remind to this ticket, maybe to be solved in 5.8.0?
Unfortunately there are more and more mails with these silly graphic files so that it becomes more and more harder to find the real attached (important) files.

Thanks a lot!

bahnkonzept

bahnkonzept

2022-11-10 07:57

reporter   ~0016367

Dear Sogo-Team,

any news about this ticket, maybe to be solved in 5.8.0?

Today I got an email from an advocacy with a lot of these silly embedded graphics and the sentence "please see the attached ...". After clicking through all the images I learned that they forgot to attach the file ...

Thanks a lot!

sebastien

sebastien

2022-11-17 14:38

administrator   ~0016395

Dear @bahnkonzept,

Thank you for reporting this improvement and apologies for the late reply.
Unfortunately we won't have enough time to improve this for the next release. Your request will be added to the feature list ;)

Sebastien

bahnkonzept

bahnkonzept

2023-03-01 18:53

reporter   ~0016708

Dear Sogo-Team,

any news about this ticket? It would be great, if it could be solved in 5.8.1?

The missing feature to supress the embedded pictures becomes more and more annoying in the really good groupware.

Thanks a lot!

sebastien

sebastien

2023-03-02 10:34

administrator   ~0016709

Hi,

Just to give some news, this has been accepted in roadmap but not in 5.8.1.
Unfortunately I can't provide an estimated time of arrival for now

Sebastien

bahnkonzept

bahnkonzept

2023-09-16 16:45

reporter   ~0017265

Dear Sogo-Team,

any news about this ticket? As the roadmap page (https://bugs.sogo.nu/roadmap_page.php) seems to be a little outdated I want to renew our interest in this little solution which would improve the usability of the webmail client and and helps us not to overlook important attachments (like drawings, photos ...) when users in your company are forced to HTML attachments with many integrated images.

It would be great, if it could be solved in 5.9.0 or sooner.

Thanks a lot!

sebastien

sebastien

2023-09-18 08:40

administrator   ~0017267

Dear @bahnkonzept,

Thank you for your interest on SOGo.
I apologize, but our current workload does not let us realizing this development. We're also looking on the BIMI implementation inside SOGo. This is unfortunately not something we can achieve in few days.

I didn't know that mantis can provide roadmap plan to user, this is a good idea !

Sebastien

bahnkonzept

bahnkonzept

2023-09-28 18:57

reporter   ~0017322

Dear Sébastien,

thank you very much for your answer. Just to ensure that we do not have a misunterstanding here:
Our long lasting request is, that image files, that are already displayed in the message part of an HTML email (regardless of whether the user is using the HTML or plain text view) are NOT shown again in the list of attached files. This is the behaviour in all frequently used mailers and would greatly improve manageability in SoGo.

This has nothing to do with the implementation of the BIMI (see https://en.wikipedia.org/wiki/Brand_Indicators_for_Message_Identification
for more informtion) you are talking about. This could be done as spearate feature in a later version as this might be a source of new errors or needed configuartions.

Best regards,

the Bahnkonzept team form Dresden/Germany

mathilde

mathilde

2023-10-04 13:10

reporter   ~0017337

Hello,

Just chiming in to say that this issue has been causing major concern to everyone I know using SOGo with images in their HTML signatures. A fix would indeed be very welcome.

Thanks for your work Sebastien!
Best,

sebastien

sebastien

2023-10-09 08:09

administrator   ~0017349

Thank you that's clear, we will discuss it

Sebastien

sebastien

sebastien

2023-10-23 10:14

administrator   ~0017389

Hi this will be integrated in 5.9.1 or 5.10.

Sebastien

bahnkonzept

bahnkonzept

2023-10-23 10:56

reporter   ~0017390

Dear Sébastien,

thank you very much for your notice and this beacon of hope for SoGo. As this handling of attachments seems to be related with the bug in ticket 0005877 (https://bugs.sogo.nu/view.php?id=5877) too, maybe it's worth to have a common look on it.

If you need some testing with a nightly build or translation support please let us know. We'll try to support as soon as possible, but please allow some days for reaction.

Best regards,

The Bahnkonzept team from Dresden/Germany

sebastien

sebastien

2023-11-01 17:27

administrator   ~0017403

Last edited: 2023-11-02 08:47

Hi,

For the other issue, no eta for now.
For this one, here is the commit : https://github.com/Alinto/sogo/commit/abce5f42cf4daef721ebf6b48d727eb957e20b14
You need to enable the option in preferences to hide inline attachments. You can try next nightly build.

[EDIT] : Small fix in commit https://github.com/Alinto/sogo/commit/f41ab2ed0c71903b80bda66adc54cc94b0cf70d6 should work in nightly build 03/11

Sebastien

bahnkonzept

bahnkonzept

2023-11-03 16:01

reporter   ~0017406

Dear Sébastien,

Thank you for the work, it works after the first initial tests on the test platform with the nightly build from 03.11.2023. We will carry out further tests in the next few days. Before we roll it out for a beta test, we would like to ask that no bracket symbol is displayed in the overview for corresponding e-mails where the inline attachments are hidden (depending on the configuration selection) (see file 2023-11-03 ScreenshotInboxE-MailSoGoGroupware.png). In the attached image, only one (marked) entry contains a real attachment, all other mails have no real attachments, only inline images.

One more question: In which value is the configuration saved? We would like to set this setting "Hide inline attachments" for all users via Admin.

Best regards,

The Bahnkonzept team from Dresden/Germany

bahnkonzept

bahnkonzept

2023-11-03 16:03

reporter   ~0017407

... here the attachment file 2023-11-03 ScreenshotInboxE-MailSoGoGroupware.png

sebastien

sebastien

2023-11-06 07:44

administrator   ~0017412

Brackets works correctly on my sidde (check attachements - tested on demo.sogo.nu).
You can use SOGoMailHideInlineAttachments (user domain) as described in documentation https://github.com/Alinto/sogo/blob/master/Documentation/SOGoInstallationGuide.asciidoc

Sebastien

bahnkonzept

bahnkonzept

2023-11-06 13:52

reporter   ~0017413

Dear Sébastien,

We have taken another close look at how the brackets are displayed in the mail overview. Your presentation is correct, but so is ours. Why?

Your tests related to mails that were received AFTER the option was activated in SoGo (no brackets are displayed) and our feedback related to mails that were received BEFORE the option was activated in SoGo (brackets are displayed).
In this respect, the problem disappears in terms of consistency (attachments are also hidden in mails that were received BEFORE the option was activated in SoGo), but the problem will no longer occur in a few weeks.

We would therefore leave it up to you to decide whether you want to fix this flaw or just document it.

Best regards,

The Bahnkonzept team from Dresden/Germany

bahnkonzept

bahnkonzept

2023-11-06 14:22

reporter   ~0017414

ONE MORE THING: Shouldn't the same behaviour as with inline images also occur with digital signatures?

These are also checked / validated and displayed in SoGo webmail, so that there is no need to download the file (smime.p7s) and the bracket in the mail overview is also more than confusing.

(We have a mail partner in the scientific environment where e-mails are always digitally signed. This means that I cannot recognise whether a "real" attachment (files such as PDF, Excel, CSV, ZIP) is attached to any email ...)

sebastien

sebastien

2023-11-07 07:13

administrator   ~0017415

Can you provide the problematic eml ? There is no link between old and new messages.

Sebastien

bahnkonzept

bahnkonzept

2023-11-10 07:00

reporter   ~0017419

Sebastien, for sure we can provide eml. Please allow some time as we have to remove some data for privacy reasons.

But are you sure that this will help, as it appears for all > 2000 emails in the inbox for the time BEFORE the nightly build was installed. For almost every AFTER the nightly build was installed there are no brackets as expected (for some emails we have a strange behaviour, but still investigate and will informa later).

sebastien

sebastien

2023-11-13 09:02

administrator   ~0017425

Hi,

This feature hides inline images if the parameter is set in the preferences.

  • smime.p7s is an attachement (check the source of the mail) so this is not related to this feature
  • I have tested with older mails and I can not reproduce your case. Please check the source mail you should not have Content-Disposition: attachment

Sebastien

bahnkonzept

bahnkonzept

2023-11-14 12:18

reporter   ~0017430

OK, so I suggest to leave the smime.p7s attachements out of this discussion and maybe check later in a separate ticket (if relevant).

bahnkonzept

bahnkonzept

2023-11-14 15:27

reporter   ~0017431

Dear Sébastien,

We did some further investigation now and created a little overview table for all the cases. From our point of view, there are two problems left:

1) Brackets in mail listing still visible, although Content-Disposition is set to inline

In mails from example 1 and 4, the Content-Disposition are set to inline but the Brackets are still shown is the email listing although the "hide inline attachment" setting is enabled and the mails to not contain any other attachments.

2) Inconsistent display of brackets in mail listing

Example 2 and 3 are missing the Content-Disposition for the attachments included within the mail body. So attachments are used inline, but not explicitly declared as inline.

But in example 2, the brackets in the mail listing are not shown whereas in example 3, the brackets are shown.

So we understand, that there is no clear way to detect the attachements as "inline only" or as regular attachment in these cases.
But at least, the output (brackets shown or not shown) should be the same for the same input (Content-Disposition missing).

It would be great, if we could crosscheck by an nightly build at the end of this week.

Best regards,

The Bahnkonzept team from Dresden/Germany

bahnkonzept

bahnkonzept

2023-11-14 17:36

reporter   ~0017432

As it was not possible to attach the files (see 0005901 for more information) to the notice from 2023-11-14 16:27

Unfortunately, we are not able to add any attachments (see 0005901 for more information) to the notice from 2023-11-14 16:27, so we created pastebins and uploaded the overview table:

sebastien

sebastien

2023-11-17 09:49

administrator   ~0017442

Fixed some bracket issues in commit https://github.com/Alinto/sogo/commit/ca2c5c188ed980629f494e5b8e23ba42cdd54f58
Behavior in mail rendering was ok.

To make this feature working correctly, parts must have the disposition inline set for images.

Sebastien

bahnkonzept

bahnkonzept

2023-11-17 10:16

reporter   ~0017443

Dear Sébastien, thank you very much. Will this be available in the nightly build tomorrow (Saturday)? Then we'll investigate tomorrow and give feedback to you.

sebastien

sebastien

2023-11-17 15:02

administrator   ~0017444

Yes tomorrow's nightly build

bahnkonzept

bahnkonzept

2023-11-18 18:33

reporter   ~0017445

Dear Sébastien,

we implemented the nightly build of Saturday (2023-11-18) and it worked much better. We'll monitor during the next weeks and will report unexpected behaviour as well as well as frenetic cheering from the users in our company.

Only one small issue, which can be solved in next main version: After we used ''SOGoMailHideInlineAttachments'' as described in [[https://github.com/Alinto/sogo/blob/master/Documentation/SOGoInstallationGuide.asciidoc|your documentation]] the feature was set for all users, which is the intended behaviour.
But in the users preference section the checkbox for //Hide inline attachements// is not set, so that the behaviour does not fit to the status in preference section. It can be solved by checking manually and saving some times but could be corrected.

Best regards,

The Bahnkonzept team from Dresden/Germany

sebastien

sebastien

2023-11-20 11:05

administrator   ~0017449

Default value is now ok https://github.com/Alinto/sogo/commit/aa535247513b06804fce666fe20ebcc9bd231c1f please test next NB

Sebastien

sebastien

sebastien

2024-01-17 09:11

administrator   ~0017534

Hi there,

The feature has changed in this commit : https://github.com/Alinto/sogo/commit/a6fc83c35bf62430b4a626107ff62cfcf9532539
Now the option is applied only for inline images.
The reason is when the option is enabled and an inline pdf is sent, there is no way to see the attachement except disabling this option.

This change will be introduced in nightly sogo--5.9.1.20240118.

Please answer to this ticket if you have issues

Sebastien

Issue History

Date Modified Username Field Change
2022-03-10 15:38 bahnkonzept New Issue
2022-03-10 15:38 bahnkonzept File Added: Screenshot 2022-03-08 at 17-42-01 Posteingang Groupware.png
2022-09-09 16:05 bahnkonzept Note Added: 0016214
2022-11-10 07:57 bahnkonzept Note Added: 0016367
2022-11-17 14:36 sebastien Severity minor => feature
2022-11-17 14:38 sebastien Note Added: 0016395
2023-03-01 18:53 bahnkonzept Note Added: 0016708
2023-03-02 10:34 sebastien Note Added: 0016709
2023-09-16 16:45 bahnkonzept Note Added: 0017265
2023-09-18 08:40 sebastien Note Added: 0017267
2023-09-28 18:57 bahnkonzept Note Added: 0017322
2023-10-04 13:10 mathilde Note Added: 0017337
2023-10-09 08:09 sebastien Note Added: 0017349
2023-10-23 10:14 sebastien Note Added: 0017389
2023-10-23 10:56 bahnkonzept Note Added: 0017390
2023-11-01 17:27 sebastien Note Added: 0017403
2023-11-01 17:27 sebastien Fixed in Version => 5.10.0
2023-11-01 17:27 sebastien Assigned To => sebastien
2023-11-01 17:27 sebastien Status new => feedback
2023-11-02 08:47 sebastien Note Edited: 0017403
2023-11-03 09:30 sebastien Status feedback => resolved
2023-11-03 09:30 sebastien Resolution open => fixed
2023-11-03 16:01 bahnkonzept Status resolved => feedback
2023-11-03 16:01 bahnkonzept Resolution fixed => reopened
2023-11-03 16:01 bahnkonzept Note Added: 0017406
2023-11-03 16:03 bahnkonzept Note Added: 0017407
2023-11-03 16:03 bahnkonzept File Added: 2023-11-03 ScreenshotPosteingangE-MailSoGoGroupware.png
2023-11-03 16:03 bahnkonzept Status feedback => assigned
2023-11-06 07:44 sebastien Note Added: 0017412
2023-11-06 07:44 sebastien File Added: Capture d’écran 2023-11-06 à 08.44.07.png
2023-11-06 07:44 sebastien File Added: Capture d’écran 2023-11-06 à 08.44.03.png
2023-11-06 09:42 sebastien Status assigned => feedback
2023-11-06 13:52 bahnkonzept Note Added: 0017413
2023-11-06 13:52 bahnkonzept Status feedback => assigned
2023-11-06 14:22 bahnkonzept Note Added: 0017414
2023-11-07 07:13 sebastien Note Added: 0017415
2023-11-10 07:00 bahnkonzept Note Added: 0017419
2023-11-13 09:02 sebastien Note Added: 0017425
2023-11-13 09:02 sebastien Status assigned => feedback
2023-11-14 12:18 bahnkonzept Note Added: 0017430
2023-11-14 12:18 bahnkonzept Status feedback => assigned
2023-11-14 15:27 bahnkonzept Note Added: 0017431
2023-11-14 17:36 bahnkonzept Note Added: 0017432
2023-11-17 09:49 sebastien Note Added: 0017442
2023-11-17 09:49 sebastien Status assigned => feedback
2023-11-17 10:16 bahnkonzept Note Added: 0017443
2023-11-17 10:16 bahnkonzept Status feedback => assigned
2023-11-17 15:02 sebastien Note Added: 0017444
2023-11-18 18:33 bahnkonzept Note Added: 0017445
2023-11-20 11:05 sebastien Note Added: 0017449
2023-11-20 11:05 sebastien Status assigned => resolved
2023-11-20 11:05 sebastien Fixed in Version 5.10.0 => 5.9.1
2024-01-17 09:11 sebastien Note Added: 0017534
2024-01-17 09:12 sebastien Status resolved => feedback
2024-05-22 09:10 sebastien Status feedback => resolved