View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0001022||SOGo||SOPE||public||2010-12-01 18:58||2011-05-10 19:58|
|Fixed in Version||1.3.8|
|Summary||0001022: specific mail crashes sogo in SOPE NGMimeRFC822DateHeaderFieldParser|
attached mail crashed sogo with following backtrace:
This happened when scrolling through my trash folder, I only found one mail with the date from the backtrace in the Trash folder. I copied it into a test folder with thunderbird. Afterwards I was suddenly able to enter the test folder without the crasher. diff -u of both mail files on the imap server showed no difference.
I'm on OpenBSD i386, using sope and sogo 1.3.4, and gnustep-base-1.18.0p2
IMAP Server is cyrus imapd.
|Tags||No tags attached.|
mail.txt (2,767 bytes)
Return-Path: <owner-tech+M21683@openbsd.org> Received: from smtp.l00-bugdead-prods.de ([unix socket]) by communicator.ds9 (Cyrus v2.3.14) with LMTPA; Thu, 30 Sep 2010 19:55:25 +0200 X-Sieve: CMU Sieve 2.3 Received: from localhost (localhost [127.0.0.1]) by smtp.l00-bugdead-prods.de (Postfix) with ESMTP id 0BC7875802 for <email@example.com>; Thu, 30 Sep 2010 19:55:25 +0200 (CEST) X-Virus-Scanned: amavisd-new at l00-bugdead-prods.de Received: from smtp.l00-bugdead-prods.de ([127.0.0.1]) by localhost (communicator.ds9 [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n9y6m5Dh4WLI for <firstname.lastname@example.org>; Thu, 30 Sep 2010 19:55:14 +0200 (CEST) Received: from shear.ucar.edu (lists.openbsd.org [22.214.171.124]) by smtp.l00-bugdead-prods.de (Postfix) with ESMTP id 2175275804 for <email@example.com>; Thu, 30 Sep 2010 19:55:13 +0200 (CEST) Received: from openbsd.org (localhost.ucar.edu [127.0.0.1]) by shear.ucar.edu (8.14.3/8.14.3) with ESMTP id o8UHs2x7023659; Thu, 30 Sep 2010 11:54:02 -0600 (MDT) Received: from cg-p00-fb.rzone.de (cg-p00-fb.rzone.de [126.96.36.199]) by shear.ucar.edu (8.14.3/8.14.3) with ESMTP id o8UHq5T3014585 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO) for <firstname.lastname@example.org>; Thu, 30 Sep 2010 11:52:08 -0600 (MDT) Received: from cg-p00-ob.rzone.de (snori-cg-p00-ob.mail [192.168.63.33]) by snori-fb-03.store (RZmta 23.5) with ESMTP id i0205fm8SGfUe2 ; Tue, 28 Sep 2010 23:51:43 +0200 (MEST) X-RZG-CLASS-ID: cg00 Received: from hublander.store ([192.168.40.230]) by snori-cg-03.store (RZmta 23.5) with ESMTP id v05695m8S8JCI0 ; Tue, 28 Sep 2010 10:51:23 +0200 (MEST) Received: (from Unknown UID 1271990@localhost) by post.webmailer.de (8.13.7/8.13.7) id o8S8pKuE021007; Tue, 28 Sep 2010 08:51:20 GMT Date: Tue, 28 Sep 2010 08:51:20 GMT Message-Id: <201009280851.o8S8pKuE021007@post.webmailer.de> To: email@example.com, firstname.lastname@example.org, email@example.com, JOHN.STANLEY@VA.GOV, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, dswestfall@KAUFCAN.COM, email@example.com, firstname.lastname@example.org Subject: susangoe sford From: "Sappawit.J" <email@example.com> X-RZG-SCRIPT: :fj1WOxH5LLG7PsZR7EjRW1CiW9fjd6ElUGTGpHx5DIxQoeBRjt1frnXuNFoKA78UJzO9mTgSGUkypAjuFSJdTEdNpZbZs/evKAcV2rq4UUF/M3L0 List-Help: <mailto:firstname.lastname@example.org?body=help> List-Owner: <mailto:email@example.com> List-Post: <mailto:firstname.lastname@example.org> List-Subscribe: <mailto:email@example.com?body=sub%20tech> List-Unsubscribe: <mailto:firstname.lastname@example.org?body=unsub%20tech> X-Loop: email@example.com Precedence: list Sender: firstname.lastname@example.org http://devaitsin887.newmail.ru/abekoqi.html
mail.txt (2,767 bytes)
Works for me too.
Are you sure you're using the "Inverse" version of SOPE?
Why do you think I don't use it? Do you have seen sth. unusual in the backtrace?
Yes, I use the Inverse version of SOPE. I use the port I created for OpenBSD:
As promised in the e-mail I sent, meanwhile some time ago, I'll probably start on the weekend to open some bug reports, and attaching the patches I have, and explain in detail, what they are good for.
sogod SOGoDraftsFolderName INBOX.Drafts
Try to add WOMessageUseUTF8 = YES to your configuration and see if the crashers are still there.
Also set WOParsersUseUTF8 = YES.
If you're still getting errors, you might want to give us SSH access, a test account and sudo access for gdb to test this on OpenBSD.
Only the abort in libiconv_close still seems to be there.
I still get this error with 1.3.7, and had some time on the weekend to spend a couple of hours to further debug the problem. I came up with attached patch, fixing the problem for me. I found that the problem only happens on timezones that are just only i.e. GMT instead "GMT +100" or the like.
I now only call digitsString(p) in case the strlen of p is > 0.
please review this patch, and consider for inclusion to sope.
You forgot to attach the patch!
sorry, now the patch is attached (:
Thanks Ludovic for taking the patch. But as I was told by a fellow OpenBSD porter, the second part of the patch is superfluous:
@@ -186,7 +189,9 @@ static NSTimeZone *parseTimeZone(const c
so free(digits), even if it is NULL, is valid C (I verified by reading up on that, and recompiled without that part of the patch, and it doesn't crash)
Fix updated and pushed.
|2010-12-01 18:58||buzzdee||New Issue|
|2010-12-01 18:58||buzzdee||File Added: mail.txt|
|2010-12-01 22:09||ludovic||Note Added: 0001906|
|2010-12-02 07:26||buzzdee||Note Added: 0001907|
|2010-12-02 15:45||ludovic||Note Added: 0001917|
|2010-12-02 15:47||ludovic||Note Added: 0001918|
|2010-12-02 15:47||ludovic||Note Added: 0001919|
|2010-12-02 18:16||buzzdee||Note Added: 0001922|
|2011-02-15 22:02||ludovic||Status||new => assigned|
|2011-02-15 22:02||ludovic||Assigned To||=> ludovic|
|2011-05-09 07:38||buzzdee||Note Added: 0002446|
|2011-05-09 15:52||ludovic||Note Added: 0002448|
|2011-05-09 15:57||buzzdee||File Added: patch-sope-mime_NGMime_NGMimeRFC822DateHeaderFieldParser_m.orig|
|2011-05-09 15:57||buzzdee||Note Added: 0002449|
|2011-05-09 20:43||ludovic||Note Added: 0002451|
|2011-05-09 20:43||ludovic||Status||assigned => resolved|
|2011-05-09 20:43||ludovic||Fixed in Version||=> 1.3.8|
|2011-05-09 20:43||ludovic||Resolution||open => fixed|
|2011-05-10 12:59||buzzdee||Note Added: 0002454|
|2011-05-10 12:59||buzzdee||Status||resolved => feedback|
|2011-05-10 12:59||buzzdee||Resolution||fixed => reopened|
|2011-05-10 19:58||ludovic||Note Added: 0002456|
|2011-05-10 19:58||ludovic||Status||feedback => resolved|
|2011-05-10 19:58||ludovic||Resolution||reopened => fixed|
|2011-05-13 11:03||ludovic||Relationship added||has duplicate 0001021|