0003306: Comma in display name of meeting organiser not handled correctly. - SOGo | BTS

ID	Project	Category	View Status	Date Submitted	Last Update

0003306	SOGo	with SOGo	public	2015-08-12 16:05	2015-09-03 18:17

Reporter	ams077	Assigned To	francis
Priority	normal	Severity	minor	Reproducibility	always
Status	resolved	Resolution	fixed
Platform	[Server] Linux	OS	Debian	OS Version	7 (Wheezy)
Product Version	2.3.1
Target Version	2.3.2	Fixed in Version	2.3.2

Summary	0003306: Comma in display name of meeting organiser not handled correctly.
Description	When accepting an invite from someone with a comma in their displaname, SOGo messes up the 'to' header in the acceptance notification email.
Steps To Reproduce	Receive an event invite from someone with a comma in their displayname. E.g. """ ORGANIZER;RSVP=TRUE;CN="Sheppard, Alex";PARTSTAT=ACCEPTED;ROLE=CHAIR:mailto:alex@das-computer.co.uk """ Accept the invite SOGo messes up the 'to' header when trying to send the invite acceptance notification. E.g. """ to: Sheppard, "Alex" <alex@das-computer.co.uk> """
Additional Information	It looks like SOGo has a lot of problems with commas in displaynames. These bugs may be related? http://www.sogo.nu/bugs/view.php?id=3301 http://www.sogo.nu/bugs/view.php?id=3298 http://www.sogo.nu/bugs/view.php?id=3296
Tags	No tags attached.

tfu 2015-08-13 20:31 reporter	mailAddrWithComma.diff (992 bytes) diff --git a/sope-mime/NGMail/NGMailAddressParser.m b/sope-mime/NGMail/NGMailAddressParser.m index 4b4e02d..1413e63 100644 --- a/sope-mime/NGMail/NGMailAddressParser.m +++ b/sope-mime/NGMail/NGMailAddressParser.m @@ -378,7 +378,7 @@ static inline id parseDomainLiteral(NGMailAddressParser self, BOOL _guessMode) NSMutableString remainder; NSMutableArray* addressList; NSString address, displayName; - NSRange r, c; + NSRange r, c, a; NSCharacterSet whitespace; NSUInteger addrStart, addrEnd, commaPos; @@ -406,7 +406,8 @@ static inline id parseDomainLiteral(NGMailAddressParser self, BOOL _guessMode) r = [remainder rangeOfString: @"<"]; addrStart = r.location; - c = [remainder rangeOfString: @","]; + a = [remainder rangeOfString: @"@"]; + c = [remainder rangeOfString: @"," options:0 range:NSMakeRange(a.location+1, [remainder length]-a.location-1)]; commaPos = c.location; if ((addrStart == NSNotFound) \|\| (commaPos < addrStart)) mailAddrWithComma.diff (992 bytes)

tfu 2015-08-13 20:31 reporter ~0008820	Attach SOPE patch should fix the described problem.

sogobug 2015-08-24 15:12 reporter ~0008851	This patch fixed http://www.sogo.nu/bugs/view.php?id=3301 too. This is quite an annoying bug since the reply-to from the mail is also wrong. The answers to these mails are sent to invalid addresses then. Please fix this in a nightly build or bugfix release. There was a similar bug before, see http://www.sogo.nu/bugs/view.php?id=2267

francis 2015-09-03 18:17 administrator ~0008888 Last edited: 2015-09-03 18:17	Thanks tfu! https://github.com/inverse-inc/sope/commit/7dcb6a244b5cdf5812541d5ddba9c63994ec7eb7

Date Modified	Username	Field	Change
2015-08-12 16:05	ams077	New Issue
2015-08-13 20:31	tfu	File Added: mailAddrWithComma.diff
2015-08-13 20:31	tfu	Note Added: 0008820
2015-08-24 15:12	sogobug	Note Added: 0008851
2015-08-25 19:55	francis	Target Version	=> 2.3.2
2015-08-27 08:37	Christian Mack	Relationship added	duplicate of 0003301
2015-09-03 18:17	francis	Note Added: 0008888
2015-09-03 18:17	francis	Status	new => resolved
2015-09-03 18:17	francis	Fixed in Version	=> 2.3.2
2015-09-03 18:17	francis	Resolution	open => fixed
2015-09-03 18:17	francis	Assigned To	=> francis
2015-09-03 18:17	francis	Note Edited: 0008888