View Issue Details

IDProjectCategoryView StatusLast Update
0006060SOGoBackend Mailpublic2024-11-14 19:07
Reporterdlb Assigned Tosebastien  
PriorityhighSeveritymajorReproducibilityalways
Status closedResolutionno change required 
Product Version5.11.2 
Summary0006060: Signatures can't be modified/saved
Description

When adding or updating a signature, everything seems to works fine but no changes are recorded.
No errors are reported, a new signature just don't get recorded and modifying an existing signature won't update it.

Steps To Reproduce

From the UI: Preferences (the wheel on top left) > Mailer > IMAP account > click on the pen to edit the account
In the identities section, use the arrow to open the identity details
in the "Signature" box, add some contents
Click on the OK button on bottom right
Click on the "save preferences" disk button ( a pop-up indicates that preferences are saved)
re-edit the account with a click on the pen button
use the arrow to open the id details
-> signature is blank

TagsNo tags attached.

Activities

sebastien

sebastien

2024-11-14 08:29

administrator   ~0017941

I can't reproduce on https://demo.sogo.nu/SOGo/, can you have a try on it ?

Sebastien

sebastien

sebastien

2024-11-14 08:37

administrator   ~0017942

You can use one of those credentials : sogo1 / sogo, sogo2 / sogo, sogo3 / sogo

Sebastien

dlb

dlb

2024-11-14 08:46

reporter   ~0017943

Thank you for the ability to test.
I your demo, adding or modifying the signature is effectively working fine.
I notice that we don't have the same signature interface... you have a CKeditor one where we only have a basic HTML field (screenshot added)
Did we miss something in the config/settings?

Version 5.11.2 (@4da6fc506394 202411110749)

dlb

dlb

2024-11-14 08:47

reporter   ~0017944

This is what we see in your demo

sebastien

sebastien

2024-11-14 09:00

administrator   ~0017945

Do you javascript have errors in your browser console ?
How did you installed SOGo ?

sebastien

sebastien

2024-11-14 09:01

administrator   ~0017946

And what is your SOGo version ?

dlb

dlb

2024-11-14 09:13

reporter   ~0017948

It seems we got a problem loading some resources...

sebastien

sebastien

2024-11-14 09:36

administrator   ~0017949

You may have to check your apache or nginx configuration - look at the network tab, when reloading the page, you must have a ressource https://xxxxxxxx/SOGo.woa/WebServerResources/js/vendor/ckeditor/build/ckeditor.js?lm=1731573883 loaded

dlb

dlb

2024-11-14 10:04

reporter   ~0017950

No I don't find this resource in the network panel after a reload.
And for what i remember, we did something related to some bugs when you switched to CKE v4 to v5 (cf. https://bugs.sogo.nu/view.php?id=5920); if i'm recall it correctly, we did add the "config.versionCheck = false;" to the WebServerResources/js/vendor/ckeditor/config.js file.
I can see that in our installation we have a backup of the file /usr/lib/GNUstep/SOGo/WebServerResources/js/vendor/ckeditor/config.js but this file seems to not exists anymore.
Was there any other change related to this that could explain why we are facing this issue?

dlb

dlb

2024-11-14 10:14

reporter   ~0017951

For info, we added the "SOGoForceRawHtmlSignature = NO;" setting in sogo.conf but this does not help having CKEditor instead of the raw one.

sebastien

sebastien

2024-11-14 11:02

administrator   ~0017952

The config.versionCheck = false; is useless for now with the update to CKEditor 5. The config.js file is obsolete.

root@96677c3202a5:/src/SOGo# tree /usr/local/lib/GNUstep/SOGo/WebServerResources/js/vendor/ckeditor/
/usr/local/lib/GNUstep/SOGo/WebServerResources/js/vendor/ckeditor/
|-- LICENSE.md
|-- build
|   |-- ckeditor.d.ts
|   |-- ckeditor.js
|   |-- ckeditor.js.map
|   `-- translations
|       |-- af.js
|       |-- ar.js
|       |-- ast.js
|       |-- az.js
|       |-- bg.js
|       |-- bn.js
|       |-- bs.js
|       |-- ca.js
|       |-- cs.js
|       |-- da.js
|       |-- de-ch.js
|       |-- de.js
|       |-- el.js
|       |-- en-au.js
|       |-- en-gb.js
|       |-- eo.js
|       |-- es-co.js
|       |-- es.js
|       |-- et.js
|       |-- eu.js
|       |-- fa.js
|       |-- fi.js
|       |-- fr.js
|       |-- gl.js
|       |-- gu.js
|       |-- he.js
|       |-- hi.js
|       |-- hr.js
|       |-- hu.js
|       |-- hy.js
|       |-- id.js
|       |-- it.js
|       |-- ja.js
|       |-- jv.js
|       |-- kk.js
|       |-- km.js
|       |-- kn.js
|       |-- ko.js
|       |-- ku.js
|       |-- lt.js
|       |-- lv.js
|       |-- ms.js
|       |-- nb.js
|       |-- ne.js
|       |-- nl.js
|       |-- no.js
|       |-- oc.js
|       |-- pl.js
|       |-- pt-br.js
|       |-- pt.js
|       |-- ro.js
|       |-- ru.js
|       |-- si.js
|       |-- sk.js
|       |-- sl.js
|       |-- sq.js
|       |-- sr-latn.js
|       |-- sr.js
|       |-- sv.js
|       |-- th.js
|       |-- tk.js
|       |-- tr.js
|       |-- tt.js
|       |-- ug.js
|       |-- uk.js
|       |-- ur.js
|       |-- uz.js
|       |-- vi.js
|       |-- zh-cn.js
|       `-- zh.js
|-- package.json
|-- sample
|   |-- index.html
|   `-- script.js
|-- src
|   `-- ckeditor.ts
|-- tsconfig.json
`-- webpack.config.js

5 directories, 80 files
dlb

dlb

2024-11-14 11:19

reporter   ~0017953

/usr/lib/GNUstep/SOGo/WebServerResources/js/vendor/ckeditor/
├── build
│   ├── ckeditor.d.ts
│   ├── ckeditor.js
│   ├── ckeditor.js.map
│   └── translations
│   ├── af.js
│   ├── ar.js
│   ├── ast.js
│   ├── az.js
│   ├── bg.js
│   ├── bn.js
│   ├── bs.js
│   ├── ca.js
│   ├── cs.js
│   ├── da.js
│   ├── de-ch.js
│   ├── de.js
│   ├── el.js
│   ├── en-au.js
│   ├── en-gb.js
│   ├── eo.js
│   ├── es-co.js
│   ├── es.js
│   ├── et.js
│   ├── eu.js
│   ├── fa.js
│   ├── fi.js
│   ├── fr.js
│   ├── gl.js
│   ├── gu.js
│   ├── he.js
│   ├── hi.js
│   ├── hr.js
│   ├── hu.js
│   ├── hy.js
│   ├── id.js
│   ├── it.js
│   ├── ja.js
│   ├── jv.js
│   ├── kk.js
│   ├── km.js
│   ├── kn.js
│   ├── ko.js
│   ├── ku.js
│   ├── lt.js
│   ├── lv.js
│   ├── ms.js
│   ├── nb.js
│   ├── ne.js
│   ├── nl.js
│   ├── no.js
│   ├── oc.js
│   ├── pl.js
│   ├── pt-br.js
│   ├── pt.js
│   ├── ro.js
│   ├── ru.js
│   ├── si.js
│   ├── sk.js
│   ├── sl.js
│   ├── sq.js
│   ├── sr.js
│   ├── sr-latn.js
│   ├── sv.js
│   ├── th.js
│   ├── tk.js
│   ├── tr.js
│   ├── tt.js
│   ├── ug.js
│   ├── uk.js
│   ├── ur.js
│   ├── uz.js
│   ├── vi.js
│   ├── zh-cn.js
│   └── zh.js
├── LICENSE.md
├── package.json
├── sample
│   ├── index.html
│   └── script.js
├── src
│   └── ckeditor.ts
├── tsconfig.json
└── webpack.config.js

dlb

dlb

2024-11-14 11:21

reporter   ~0017954

5 directories, 80 files

it seems we got the same layout

qhivert

qhivert

2024-11-14 12:53

administrator   ~0017956

Do you have any problem with mail editor? It also uses ckeditor ans the same sgCkeditor.component.js file

dlb

dlb

2024-11-14 13:38

reporter   ~0017957

No, as weird as it could be, actually nothing strange with the mail editor, cke seems to be just fine there

qhivert

qhivert

2024-11-14 13:52

administrator   ~0017958

Inside your debugging console, do you see the webpack? and the file that defines ClassicEditor ?

ckeditor.png (284,759 bytes)
dlb

dlb

2024-11-14 13:57

reporter   ~0017959

Nope, no webpack here

qhivert

qhivert

2024-11-14 13:58

administrator   ~0017960

Last edited: 2024-11-14 14:00

And do you have the name ClassicEditor in your ckeditor.js file ?

qhivert

qhivert

2024-11-14 13:58

administrator   ~0017961

ckeditor2.png (336,627 bytes)
qhivert

qhivert

2024-11-14 14:02

administrator   ~0017962

Have you tried to delete all data and cookies and refresh sogo webpage? Have you tried another browser?

dlb

dlb

2024-11-14 14:26

reporter   ~0017963

I don't have this js file in the list (cf. screenshot).
Yes i tried to remove data and cookies related to our webmail. Just to be safe, I installed 2 other browsers (opera and vivaldi) which then have never been on this webmail and... got the exact same result

qhivert

qhivert

2024-11-14 14:30

administrator   ~0017964

And on the mail editor view do you have those webpack and files?
If yes, could you put them here?

dlb

dlb

2024-11-14 14:37

reporter   ~0017965

Yes, when on the mail view page the file is present

ckeditor.js.zip (403,104 bytes)
qhivert

qhivert

2024-11-14 15:07

administrator   ~0017966

Very strange that it works for email but not in preferences. I can't see cases where one is working but not the other.
When in preferences page, could you right-click -> View page source. And give it to me? Send it at qhivert@alinto.eu

sebastien

sebastien

2024-11-14 15:08

administrator   ~0017967

From @dlb

dlb

dlb

2024-11-14 16:51

reporter   ~0017968

You may close this issue, the problem was on our side.
Short explanation: we use a custom UIxPreferences.wox which wasn't sync with the current one and the path to ckeditor.js was wrong ("/build/" was missing).

Long explanation and background:
When TOTP was introduced, it lead to many problems with our users and we decided to disable it, at least from the interface.
To reach this goal, we used the overload technique: make a copy of /usr/lib/GNUstep/SOGo/Templates/PreferencesUI/UIxPreferences.wox to ~sogo/GNUstep/Library/SOGo/Templates/PreferencesUI/UIxPreferences.wox and comment the TOTP related section.
But this template has evolved (of course) and we didn't catch it.
So the lack of the ckeditor was because the path to the ckeditor.js file has changed and we forgot to update our custom template.
We're sorry for this inconvenience.
Let's hope a new setting could be used in the future to be able to disable TOTP without having to customize the template so we'll be safe for the future releases ^^

Issue History

Date Modified Username Field Change
2024-11-14 08:21 dlb New Issue
2024-11-14 08:29 sebastien Note Added: 0017941
2024-11-14 08:37 sebastien Note Added: 0017942
2024-11-14 08:46 dlb Note Added: 0017943
2024-11-14 08:46 dlb File Added: Capture d’écran 2024-11-14 à 09.41.07.png
2024-11-14 08:47 dlb Note Added: 0017944
2024-11-14 08:47 dlb File Added: Capture d’écran 2024-11-14 à 09.39.46.png
2024-11-14 09:00 sebastien Note Added: 0017945
2024-11-14 09:01 sebastien Note Added: 0017946
2024-11-14 09:13 dlb Note Added: 0017948
2024-11-14 09:36 sebastien Note Added: 0017949
2024-11-14 10:02 sebastien Assigned To => sebastien
2024-11-14 10:02 sebastien Status new => feedback
2024-11-14 10:04 dlb Note Added: 0017950
2024-11-14 10:04 dlb Status feedback => assigned
2024-11-14 10:14 dlb Note Added: 0017951
2024-11-14 11:02 sebastien Note Added: 0017952
2024-11-14 11:19 dlb Note Added: 0017953
2024-11-14 11:21 dlb Note Added: 0017954
2024-11-14 12:53 qhivert Note Added: 0017956
2024-11-14 12:54 qhivert Status assigned => feedback
2024-11-14 13:38 dlb Note Added: 0017957
2024-11-14 13:38 dlb Status feedback => assigned
2024-11-14 13:52 qhivert Note Added: 0017958
2024-11-14 13:52 qhivert File Added: ckeditor.png
2024-11-14 13:52 qhivert Status assigned => feedback
2024-11-14 13:57 dlb Note Added: 0017959
2024-11-14 13:57 dlb File Added: Capture d’écran 2024-11-14 à 14.55.39.png
2024-11-14 13:57 dlb Status feedback => assigned
2024-11-14 13:58 qhivert Note Added: 0017960
2024-11-14 13:58 qhivert Note Added: 0017961
2024-11-14 13:58 qhivert File Added: ckeditor2.png
2024-11-14 14:00 qhivert Note Edited: 0017960
2024-11-14 14:02 qhivert Note Added: 0017962
2024-11-14 14:02 qhivert Status assigned => feedback
2024-11-14 14:26 dlb Note Added: 0017963
2024-11-14 14:26 dlb File Added: Capture d’écran 2024-11-14 à 15.21.50.png
2024-11-14 14:26 dlb Status feedback => assigned
2024-11-14 14:30 qhivert Note Added: 0017964
2024-11-14 14:30 qhivert Status assigned => feedback
2024-11-14 14:37 dlb Note Added: 0017965
2024-11-14 14:37 dlb File Added: ckeditor.js.zip
2024-11-14 14:37 dlb Status feedback => assigned
2024-11-14 15:07 qhivert Note Added: 0017966
2024-11-14 15:07 qhivert Status assigned => feedback
2024-11-14 15:08 sebastien Note Added: 0017967
2024-11-14 15:08 sebastien File Added: Capture d’écran 2024-11-14 à 10.08.25.png
2024-11-14 16:51 dlb Note Added: 0017968
2024-11-14 16:51 dlb Status feedback => assigned
2024-11-14 19:07 sebastien Status assigned => closed
2024-11-14 19:07 sebastien Resolution open => no change required