View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0005755SOGoWeb Mailpublic2023-04-26 17:312023-06-11 12:04
Reportermstinsky Assigned Tosebastien  
PrioritynormalSeverityminorReproducibilityhave not tried
Status assignedResolutionopen 
Product Version5.8.2 
Summary0005755: Some link "buttons" in received mails are broken
Description

When users receive mails from different sources some "buttons" that should be a link are not clickable.
I dont know exactly when this happens, but for example one user got a mail with travel offers where all the link "buttons" to the website were not working.
Another user had the same issue with a link for packet tracking from amazon. I uploaded one picture of such a button.
In some other mails all buttons just work fine.

What is weird is when such a broken mail is getting forwarded to the same or different user all butons start to work in the forwarded mail.

Steps To Reproduce

So far I could not find out what specific mails trigger this issue and why.

TagsNo tags attached.

Activities

mstinsky

mstinsky

2023-04-26 17:31

reporter  

broken_link_button.png (721,748 bytes)
broken_link_button2.png (10,376 bytes)   
broken_link_button2.png (10,376 bytes)   
sebastien

sebastien

2023-04-26 18:44

administrator   ~0016907

Please provide eml file

Sebastien
mstinsky

mstinsky

2023-04-26 19:19

reporter   ~0016908

Any recommendations on how to anonymize user data from the eml?
Just removing addresses or should I take more into account before sharing here.
sebastien

sebastien

2023-04-26 19:47

administrator   ~0016909

You can edit with a text editor and replace sensitive data
mstinsky

mstinsky

2023-04-30 08:32

reporter   ~0016921

I uploaded one of those travel offer mails where all the buttons that normally link to the offer "ZUM ANGEBOT" are broken.
And I tested once more if I forward the mail to my own mailbox the links start working in the forwarded mail.

⭐ Stars am Sonntag_ Reiseträume werden wahr.eml (179,686 bytes)
mstinsky

mstinsky

2023-05-21 12:02

reporter   ~0016968

Did you possibly find some time to look into it? This seems to be an issue with multiple different email sources that I have and users find it quite annoying :)
If you need any more information just let me know what I could gather for you.
sebastien

sebastien

2023-05-21 20:32

administrator   ~0016969

Hi,

As explained in other tickets, we prioritize premium support.

Sebastien
mstinsky

mstinsky

2023-05-28 10:54

reporter   ~0016984

Hi Sebastien,

I totally undertsand that, sadly I have no programming experience required for the sogo project so I cant help on that front.

What I did to maybe help a bit was confirm that this seems to be a sogo bug. I setup both openxchange and roundcube as a frontend for the mailserver and in both the links in the mentioned emails are working without any problems.
If I can do anything to help just let me know :)
sebastien

sebastien

2023-06-05 20:58

administrator   ~0016999

Last edited: 2023-06-05 20:59

Your email is malformed and contains invalid HTML content (tested on W3C).
You need to remove tags like <!-->.

I'll try to do a fix.
mstinsky

mstinsky

2023-06-06 06:31

reporter   ~0017000

Mhh. That seems strange.
I have other mail sources with the same issue one of them are amazon tracking mails. I looked into the amazon mail and they indeed also have tags like &lt;!--[if !gte mso 9]>&lt;!-- -->.
But its hard for me to believe that amazon sends out automated mails that are maleformed? Also not sure what other webmail clients do differently that those mails still work without any issue if those are maleformed.

As always if I can help with anything please let me know :)
And thanks for looking into it, very much appreciated!
sebastien

sebastien

2023-06-06 12:39

administrator   ~0017001

I'm not talking about the if tags but the standalone <!--> tags (check attachement). You can try this in https://validator.w3.org/nu/#textarea :

<!DOCTYPE html>
<html lang="en">
<head>
<title>This is a test</title>
</head>
<body>
This is an example for ticket 0005755 : <!-->
</body>

The body is invalid

Sebastien

Capture d’écran 2023-06-06 à 14.33.34.png (267,832 bytes)
mstinsky

mstinsky

2023-06-06 13:05

reporter   ~0017002

mh, then I am not 100% sure if that really is the issue afterall.
Like I said I also have the same issue with some of amazon's order tracking emails. I am not 100% comfortable in sharing those publicly as they contain order id's and tracking links.
I looked through the source of those emails and dont see <!--> on its own, but still links are not working in those aswell.

Ill try to find time later to maybe replace sensitive data from one of those emails aswell so you have another example from a different source.
sebastien

sebastien

2023-06-07 12:46

administrator   ~0017005

I'm repeating, even if mails are provided by Amazon the HTML is invalid <!--> and <!--<! are NOT allowed.

Here is a fix in https://github.com/Alinto/sogo/commit/f9fdad251da20617430e1626a72c574221215ff1 (next nightly build) which fixes the issue ... of your provided eml.
Let me know if you still have link issues.

Sebastien
mstinsky

mstinsky

2023-06-11 10:40

reporter   ~0017011

Hi Sebastien,

I tested the nightly build and for the sources of the provided eml the links are working again!
Sadly the amazon tracking mails are still broken. I altered one of those tracking emails with the word 'redacted' and uploaded it in this comment for you to check aswell.
The provided eml was tested in openxchange and roundcube and in both the button "Ihr Paket verfolgen" follows to the altered link "https://www.amazon.de/gp/r.html?redacted&quot; in SOGo it is not clickable.

Thank you very much for your work on this bug ticket so far, highly appreciated.

amazon.eml (40,491 bytes)
sebastien

sebastien

2023-06-11 12:04

administrator   ~0017012

Thank you for your feedback. Just to clarify the difference between SOGo and others web mail, SOGo parse HTML source using SAX parser. If xml is malformed, the mail will not load correctly.
I will have a look on the eml but I'm a little busy for now.

Sebastien

Issue History

Date Modified Username Field Change
2023-04-26 17:31 mstinsky New Issue
2023-04-26 17:31 mstinsky File Added: broken_link_button.png
2023-04-26 17:31 mstinsky File Added: broken_link_button2.png
2023-04-26 18:44 sebastien Note Added: 0016907
2023-04-26 19:19 mstinsky Note Added: 0016908
2023-04-26 19:47 sebastien Note Added: 0016909
2023-04-30 08:32 mstinsky Note Added: 0016921
2023-04-30 08:32 mstinsky File Added: ⭐ Stars am Sonntag_ Reiseträume werden wahr.eml
2023-05-21 12:02 mstinsky Note Added: 0016968
2023-05-21 20:32 sebastien Note Added: 0016969
2023-05-28 10:54 mstinsky Note Added: 0016984
2023-06-05 19:48 sebastien Assigned To => sebastien
2023-06-05 19:48 sebastien Status new => assigned
2023-06-05 20:58 sebastien Note Added: 0016999
2023-06-05 20:59 sebastien Note Edited: 0016999
2023-06-06 06:31 mstinsky Note Added: 0017000
2023-06-06 12:39 sebastien Note Added: 0017001
2023-06-06 12:39 sebastien File Added: Capture d’écran 2023-06-06 à 14.33.34.png
2023-06-06 13:05 mstinsky Note Added: 0017002
2023-06-07 12:46 sebastien Note Added: 0017005
2023-06-07 12:46 sebastien Status assigned => feedback
2023-06-11 10:40 mstinsky Note Added: 0017011
2023-06-11 10:40 mstinsky File Added: amazon.eml
2023-06-11 10:40 mstinsky Status feedback => assigned
2023-06-11 12:04 sebastien Note Added: 0017012