| Description | The TLS socket implementation in NGActiveSSLSocket currently does not verify the peer. Meaning, that any certificate is accepted, both for gnutls as with openssl.
This is quite bad, as it allows for MITM attacks, which TLS can easily prevent.
To fix this, NGActiveSSLSocket would need a host name passed (or extracted from the underlying socket) and then be verified:
GnuTLS
- Load the root CA store:
gnutls_certificate_set_x509_trust_file() or gnutls_certificate_set_x509_system_trust()
gnutls_server_name_set()with the host name
OpenSSL
- adjust the line
SSL_CTX_set_verify(self->ctx, SSL_VERIFY_NONE, NULL); to verify the peer (removing should be sufficient)
- set host name with
SSL_set_tlsext_host_name()
Generally following https://docs.fedoraproject.org/en-US/Fedora_Security_Team/1/html/Defensive_Coding/sect-Defensive_Coding-TLS-Client.html (OpenSSL) and https://docs.fedoraproject.org/en-US/Fedora_Security_Team/1/html/Defensive_Coding/sect-Defensive_Coding-TLS-Client-GNUTLS.html (GnuTLS) should be good practivce
- SSL_set_tlsext_host_name(ssl, host)
|
|---|
