View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0003628 | SOGo | Backend Calendar | public | 2016-04-11 14:27 | 2016-04-12 19:54 |
Reporter | timooms | Assigned To | ludovic | ||
Priority | low | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Platform | [Server] Linux | OS | RHEL/CentOS | OS Version | 7 |
Product Version | 2.3.10 | ||||
Fixed in Version | 2.3.11 | ||||
Summary | 0003628: unsigned int for storing offset that can be negative | ||||
Description | (at least) [SOGoAppointmentFolder _fixupRecord:] in SOGoAppointmentFolder.m is using an "unsigned int" for storing the offset. For now this causes no problems as [NSCalendarDate(OPENSTEP) dateByAddingYears:months:days:hours:minutes:seconds:] is also using int. In (at least) version 1.24.9, this is no longer the case and this is causing problems for all day events. | ||||
Steps To Reproduce | timezone: Europe/Brussels (offset: 3600 -> seconds: -3600) | ||||
Tags | No tags attached. | ||||
All the GNUstep versions I see, including 1.24.9 has the following method signature:
|
|
It's about this specific method: 2607 @implementation NSCalendarDate (OPENSTEP) last line was original (in 1.24.6) |
|
Fixed in 2.3.11 and 3.0.3. |
|
sogo: master 1e8a5652 2016-04-11 15:55 Details Diff |
(fix) adjust offset datatype to avoid int overflows (fixes 0003628) |
Affected Issues 0003628 |
|
mod - SoObjects/Appointments/SOGoAppointmentFolder.m | Diff File | ||
sogo: v2 c091c051 2016-04-11 15:55 Details Diff |
(fix) adjust offset datatype to avoid int overflows (fixes 0003628) |
Affected Issues 0003628 |
|
mod - SoObjects/Appointments/SOGoAppointmentFolder.m | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2016-04-11 14:27 | timooms | New Issue | |
2016-04-11 14:39 | ludovic | Note Added: 0009958 | |
2016-04-11 17:59 | timooms | Note Added: 0009960 | |
2016-04-11 19:56 | ludovic | Changeset attached | => sogo master 1e8a5652 |
2016-04-11 19:56 | ludovic | Assigned To | => ludovic |
2016-04-11 19:56 | ludovic | Resolution | open => fixed |
2016-04-11 19:56 | ludovic | Changeset attached | => sogo v2 c091c051 |
2016-04-12 19:54 | ludovic | Note Added: 0009968 | |
2016-04-12 19:54 | ludovic | Status | new => resolved |
2016-04-12 19:54 | ludovic | Fixed in Version | => 2.3.11 |