View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002648SOGoWeb Preferencespublic2014-03-10 16:532014-03-10 18:48
Reporterbuzzdee Assigned Tofrancis  
PriorityhighSeveritycrashReproducibilityalways
Status resolvedResolutionfixed 
Platformamd64OSOpenBSDOS Version5.2
Product Version2.2.1 
Fixed in Version2.2.2 
Summary0002648: crasher opening preferences
Description

There is an int compared with NSNotFound, which is long on 64Bit archs, and gives false results, leading to an exception when opening the preferences.

Attached patch changes the index from int to NSUInteger (return value of NSArray objectAtIndex returns NSUInteger), and that makes it again work for me.

TagsNo tags attached.

Relationships

Relationship GraphDependency Graph
related to 0002647 resolvedfrancis SOGoCalendarDefaultReminder default value does not work 

Activities

buzzdee

buzzdee

2014-03-10 16:53

reporter  

patch-UI_PreferencesUI_UIxPreferences_m (356 bytes)    
$OpenBSD$
--- UI/PreferencesUI/UIxPreferences.m.orig	Mon Mar 10 17:45:05 2014
+++ UI/PreferencesUI/UIxPreferences.m	Mon Mar 10 17:45:32 2014
@@ -568,7 +568,7 @@ static NSArray *reminderValues = nil;
 - (NSString *) reminder
 {
   NSString *value;
-  int index;
+  NSUInteger index;
 
   value = [userDefaults calendarDefaultReminder];
   if (value != nil)
patch-UI_PreferencesUI_UIxPreferences_m (356 bytes)   
francis

francis

2014-03-10 18:48

administrator   ~0006680

Fixed.

See https://github.com/inverse-inc/sogo/commit/cbd22762c35f73a8c2c3a81d7d47169a4f3c5753

Issue History

Date Modified Username Field Change
2014-03-10 16:53 buzzdee New Issue
2014-03-10 16:53 buzzdee File Added: patch-UI_PreferencesUI_UIxPreferences_m
2014-03-10 18:41 francis Relationship added related to 0002647
2014-03-10 18:48 francis Note Added: 0006680
2014-03-10 18:48 francis Status new => resolved
2014-03-10 18:48 francis Fixed in Version => 2.2.2
2014-03-10 18:48 francis Resolution open => fixed
2014-03-10 18:48 francis Assigned To => francis