0002161: If SMTP Server send Outlook-Style ExtensionInfo "AUTH=PLAIN" after standard style "AUTH PLAIN", it is ignored - Fix included - SOGo

ID	Project	Category	View Status	Date Submitted	Last Update

0002161	SOGo	SOPE	public	2013-01-07 13:29	2013-01-09 18:06

Reporter	jobisoft	Assigned To
Priority	normal	Severity	major	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	2.0.3a
Target Version	2.0.4	Fixed in Version	2.0.4

Summary	0002161: If SMTP Server send Outlook-Style ExtensionInfo "AUTH=PLAIN" after standard style "AUTH PLAIN", it is ignored - Fix included
Description	This is the ExtensionInfo from smtp.worldserver.net 250-mail01.worldserver.net 250-PIPELINING 250-SIZE 69730304 250-VRFY 250-ETRN 250-STARTTLS 250-AUTH PLAIN LOGIN CRAM-MD5 250-AUTH=PLAIN LOGIN CRAM-MD5 But SOGo fails to "see" it. Actually it does see it, but changes it back to false when analyzing AUTH=PLAIN This can be fixed _fetchExtensionInfo in NGSmtpClient.m by changing line 55 from else if ([line hasPrefix:@"AUTH"]) { to else if ([line hasPrefix:@"AUTH"] && !(self->extensions.hasAuthPlain)) {
Tags	No tags attached.

jobisoft 2013-01-08 12:57 reporter ~0005092	The solution is even more simple, added a git diff

2013-01-08 12:57	patch_2.0.3a_outlook_style_auth_plain_prevents_authentication (589 bytes)

ludovic 2013-01-09 18:06 administrator ~0005109	Fix pushed + added rationale: https://github.com/inverse-inc/sope/commit/888a2595a60f0e24a81b066651c26c5f14761fce

Date Modified	Username	Field	Change
2013-01-07 13:29	jobisoft	New Issue
2013-01-08 12:57	jobisoft	Note Added: 0005092
2013-01-08 12:57	jobisoft	File Added: patch_2.0.3a_outlook_style_auth_plain_prevents_authentication
2013-01-08 13:40	francis	Target Version	=> 2.0.4
2013-01-09 18:06	ludovic	Note Added: 0005109
2013-01-09 18:06	ludovic	Status	new => closed
2013-01-09 18:06	ludovic	Resolution	open => fixed
2013-01-09 18:06	ludovic	Fixed in Version	=> 2.0.4