|
|
Fixed: https://github.com/inverse-inc/sope/commit/180ee5442d3245265a993de4c565271bc6c5c142 |
|
|
|
I'm sorry to report, that the issue still persists. The Output of SMTP AUTH with SOGo 2.0.3:
C: connect to <0x0x7fd08b958690[NGInternetSocketAddress]: host=smtp.example.org not-filled>
S: <SMTP-Reply: code=220 line='smtp.example.org ESMTP'>
C: EHLO srv-web-01.example.local
S: <SMTP-Reply: code=250 line='DSN'>
S: pipelining extension supported.
S: size extension supported.
S: plain auth extension supported.
C: AUTH PLAIN
C: xyXYxyXYxyXYxyXYxyXYxyXYxyXYxyXYxyXYxyXYxyXYxyXYxyXYxyXYxyXYxyXYxyXYxyXY
xyXYxyXYxyXYxyXYxyXYxyXYxyXYxyXYxyXYxyX=
C: QUIT
S: <SMTP-Reply: code=502 line='5.5.2 Error: command not recognized'>
I replaced the AUTH PLAIN string for security reasons, but the length still
fits... |
|
|
|
EDIT: My original post was plain wrong and missleading, removed it later.
After playing around with it, I learned, that the linebreak indeed causes the error. Simpling replacing all "\n" in the authstring with "" solved the problem. Simple fix included. |
|
|
|
fix_2126 (829 bytes)
diff --git a/sope-mime/NGMail/NGSmtpClient.m b/sope-mime/NGMail/NGSmtpClient.m
index bb5daba..781ddd3 100644
--- a/sope-mime/NGMail/NGSmtpClient.m
+++ b/sope-mime/NGMail/NGSmtpClient.m
@@ -237,10 +237,10 @@
buffer = malloc (sizeof (char) * (buflen + 1));
sprintf (buffer, "%s%c%s%c%s",
utf8Username, 0, utf8Username, 0, utf8Password);
- authString = [[NSData dataWithBytesNoCopy: buffer
+ authString = [[[NSData dataWithBytesNoCopy: buffer
length: buflen
freeWhenDone: YES]
- stringByEncodingBase64];
+ stringByEncodingBase64] stringByReplacingOccurrencesOfString:@"\n" withString:@""];
reply = [self sendCommand: @"AUTH PLAIN"];
if ([reply code] == NGSmtpServerChallenge)
|
|
|
|
Thanks.
See https://github.com/inverse-inc/sope/commit/9c3999fadcf3b5e2de9dfbf21756eaa4b7d41e54 |
|
