0001820: SOPE build fix for arm - SOGo

ID	Project	Category	View Status	Date Submitted	Last Update

0001820	SOGo	Packaging (Debian)	public	2012-05-28 14:03	2012-05-29 20:08

Reporter	dekkers	Assigned To	ludovic
Priority	normal	Severity	minor	Reproducibility	always
Status	closed	Resolution	fixed
Target Version	1.3.16	Fixed in Version	1.3.16

Summary	0001820: SOPE build fix for arm
Description	The patch in 0001672 compares a va_list with NULL, resulting in the following error on arm: PrintfFormatScanner.m: In function '-[PrintfFormatScanner stringWithFormat:arguments:]': PrintfFormatScanner.m:36:14: error: invalid operands to binary != (have 'va_list' and 'void *') The attached patch simply does an if (args) instead of if (args != NULL).
Tags	No tags attached.

2012-05-28 14:03	sope-arm-buildfix.patch (470 bytes) diff --git a/sope-gdl1/GDLAccess/FoundationExt/PrintfFormatScanner.m b/sope-gdl1/GDLAccess/FoundationExt/PrintfFormatScanner.m index 7d4a248..de90910 100644 --- a/sope-gdl1/GDLAccess/FoundationExt/PrintfFormatScanner.m +++ b/sope-gdl1/GDLAccess/FoundationExt/PrintfFormatScanner.m @@ -33,7 +33,7 @@ #ifdef __va_copy // args being NULL breaks heavily on amd64 - if (args != NULL) { + if (args) { __va_copy(va, args); } else { return format; sope-arm-buildfix.patch (470 bytes)

ludovic 2012-05-29 20:08 reporter ~0003981	Fix applied - http://mtn.inverse.ca/revision/diff/8d5039967f59c97fd8c653e702602f80dba08abf/with/8ebc4980bb476d82acbad15b70df3600932b35f2

Date Modified	Username	Field	Change
2012-05-28 14:03	dekkers	New Issue
2012-05-28 14:03	dekkers	File Added: sope-arm-buildfix.patch
2012-05-28 14:05	ludovic	Target Version	=> 1.3.16
2012-05-29 20:08	ludovic	Note Added: 0003981
2012-05-29 20:08	ludovic	Status	new => resolved
2012-05-29 20:08	ludovic	Fixed in Version	=> 1.3.16
2012-05-29 20:08	ludovic	Resolution	open => fixed
2012-05-29 20:08	ludovic	Assigned To	=> ludovic
2012-05-29 20:08	ludovic	Status	resolved => closed