View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001594 | SOGo | SOPE | public | 2012-01-22 14:34 | 2012-06-06 14:47 |
| Reporter | buzzdee | Assigned To | ludovic | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.3.11 | ||||
| Target Version | 1.3.16 | Fixed in Version | 1.3.16 | ||
| Summary | 0001594: In -[NSObject(KeyValueCoding) takeValue:forKey:] This method is deprecated, use -setValue:forKey: --with patch | ||||
| Description | This warning shows up with OGo and SOGo, found a shared usage of the deprecated method in SOPE. Attached patch uses the new proposed method. | ||||
| Additional Information | could this please included in the next SOPE/SOGo release. | ||||
| Tags | No tags attached. | ||||
|
2012-01-22 14:34
|
patch-sope-appserver_NGObjWeb_Associations_WOKeyPathAssociation_m (1,073 bytes)
$OpenBSD$
fix deprecated warning
--- sope-appserver/NGObjWeb/Associations/WOKeyPathAssociation.m.orig Sun Jan 22 13:22:00 2012
+++ sope-appserver/NGObjWeb/Associations/WOKeyPathAssociation.m Sun Jan 22 13:29:07 2012
@@ -939,8 +939,7 @@ static BOOL _setValue(WOKeyPathAssociation *self, id _
handleUnknownKey stuff ...
*/
-#if GNUSTEP_BASE_LIBRARY && ((GNUSTEP_BASE_MAJOR_VERSION >= 1) && \
- (GNUSTEP_BASE_MINOR_VERSION >= 11))
+#if GNUSTEP_BASE_LIBRARY
// TODO: also do this for OSX 10.4? probably
[object setValue:_value forKey:info->extra.key];
#else
@@ -1097,9 +1096,9 @@ static BOOL _setValue(WOKeyPathAssociation *self, id _
return;
}
- if (info->type == WOKeyType_kvc) { // takeValue:forKey:..
+ if (info->type == WOKeyType_kvc) { // setValue:forKey:
NSCAssert(info->extra.key, @"no key object set ..");
- [_wo takeValue:uintNumObj(_value) forKey:info->extra.key];
+ [_wo setValue:uintNumObj(_value) forKey:info->extra.key];
return;
}
if (info->type == WOKeyType_binding) { // setValue:forBinding:
|
|
I missed two occurences where the deprecated method is called, the new patch contains those too. |
|
|
Patch applied - see: |
|
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-01-22 14:34 | buzzdee | New Issue | |
| 2012-01-22 14:34 | buzzdee | File Added: patch-sope-appserver_NGObjWeb_Associations_WOKeyPathAssociation_m | |
| 2012-01-22 15:10 | buzzdee | Note Added: 0003305 | |
| 2012-05-22 20:05 | ludovic | Target Version | => 1.3.16 |
| 2012-05-29 20:22 | ludovic | Note Added: 0003985 | |
| 2012-05-29 20:22 | ludovic | Status | new => resolved |
| 2012-05-29 20:22 | ludovic | Fixed in Version | => 1.3.16 |
| 2012-05-29 20:22 | ludovic | Resolution | open => fixed |
| 2012-05-29 20:22 | ludovic | Assigned To | => ludovic |
| 2012-05-29 20:22 | ludovic | Status | resolved => closed |
| 2012-06-06 14:47 | francis | Fixed in Version | 1.3.16 => |
| 2012-06-06 14:47 | francis | Target Version | 1.3.16 => |
| 2012-06-06 14:47 | francis | Fixed in Version | => 1.3.16 |
| 2012-06-06 14:47 | francis | Target Version | => 1.3.16 |