|
|
A slight problem with this is the TCP port to which we should connect for the "ManageSieve" daemon.
Cyrus defaults to 2000 on most Linux distributions while Dovecot defaults to 4190. |
|
|
|
Debian Squeeze (6.0) change default Sieve port 2000 to 4190 .
See http://www.debian.org/releases/stable/amd64/release-notes/ch-information.en.html#sieve-port-number |
|
|
|
That re-enforces my point. Sometimes it's 2000, sometimes it's 4190 - we can't assume things. |
|
|
|
Demoted until we find a nice way to specify the Sieve port when falling back on the LDAP attribute for the IMAP server. |
|
|
|
I think you can assume that the sieve port is the same on all server in the same organization. If not, user can configure sieve port on each server to be the same. |
|
|
|
Why not to specify Sieve host like IMAP host with LDAP attribute? For example SIEVEHostFieldName. |
|
|
|
I needed to solve the same problem. As there is no ready solution, and as I prepared a patch for a similar problem with setting IMAPs together with using IMAPHostFieldName (see bug 0001866), I have prepared the same solution for the problem reported here - setting Sieve server using LDAP mailHost.
In proposed patch is used SOGoSieveServer as template in which the host name will be replaced by the value of IMAPHostFieldName.
Incidentally, when preparing patches, I noticed that while the comment states that SOGoSieveServer set to "server" or "server:port" are not supported, a few lines below is exactly in this way set the Sieve server using an IMAP server name. Proposed patch also fixes this problem. |
|
|
|
sieve-ldap-hostname.diff (2,255 bytes)
Index: b/SoObjects/SOGo/SOGoSieveManager.m
===================================================================
--- a/SoObjects/SOGo/SOGoSieveManager.m 2012-07-04 18:57:44.000000000 +0200
+++ b/SoObjects/SOGo/SOGoSieveManager.m 2012-07-04 20:13:17.000000000 +0200
@@ -38,6 +38,7 @@
#import "../Mailer/SOGoMailAccount.h"
#import "SOGoSieveManager.h"
+#import "SOGoUserManager.h"
typedef enum {
UIxFilterFieldTypeAddress,
@@ -623,10 +624,12 @@
NSMutableArray *req;
NSMutableString *script, *header;
NSDictionary *result, *values;
+ NSDictionary *contactInfos;
+ SOGoUserManager *um;
SOGoUserDefaults *ud;
SOGoDomainDefaults *dd;
NGSieveClient *client;
- NSString *filterScript, *v, *sieveServer;
+ NSString *filterScript, *v, *sieveScheme, *sieveServer, *sieveQuery, *ldapImapServer;
NSURL *url;
int sievePort;
@@ -749,10 +752,16 @@
//
// Values such as "localhost" or "localhost:2000" are NOT supported.
//
+ sieveScheme = @"sieve";
sieveServer = [dd sieveServer];
sievePort = 2000;
- url = nil;
-
+ sieveQuery = @"";
+ url = [NSURL URLWithString: sieveServer];
+
+ if ([url scheme])
+ sieveScheme = [url scheme];
+ if ([url host])
+ sieveServer = [url host];
if (!sieveServer)
{
NSString *s;
@@ -770,16 +779,23 @@
else
sieveServer = s;
}
- else
- sieveServer = @"localhost";
-
- url = [NSURL URLWithString: [NSString stringWithFormat: @"%@:%d", sieveServer, sievePort]];
- }
- else
- {
- url = [NSURL URLWithString: sieveServer];
}
+ um = [SOGoUserManager sharedUserManager];
+ contactInfos = [um contactInfosForUserWithUIDorEmail: theLogin ];
+ ldapImapServer = [contactInfos objectForKey: @"c_imaphostname"];
+ if (ldapImapServer)
+ sieveServer = ldapImapServer;
+ if (!sieveServer)
+ sieveServer = @"localhost";
+ if ([url port])
+ sievePort = [[url port] intValue];
+ if ([url query])
+ sieveQuery = [NSString stringWithFormat: @"/?%@", [url query]];
+
+ url = [NSURL URLWithString: [NSString stringWithFormat: @"%@://%@:%d%@",
+ sieveScheme, sieveServer, sievePort, sieveQuery]];
+
client = [[NGSieveClient alloc] initWithURL: url];
if (!client) {
|
|
|
|
Bug fixed: https://github.com/inverse-inc/sogo/commit/7c250fad8fbee5c51dd655af23058c20a710db82
We can now define the SieveHostFieldName in LDAP/SQL sources.
The proposed patch was invalid, as IMAPHostFieldName doesn't necessarily contain just the server name, but it could also contain the protocol and port information. |
|
