View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001048 | SOGo | Web General | public | 2010-12-08 10:03 | 2010-12-08 14:30 |
| Reporter | paubry | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | duplicate | ||
| Product Version | 1.3.4 | ||||
| Summary | 0001048: Quit button still appears when SOGoCASLogoutEnabled is set to NO | ||||
| Description | UIxPageFrame.canLogoff() returns TRUE when using CAS authentication with SOGoCASLogoutEnabled set to NO (since in this case it still looks at the auth cookie). | ||||
| Tags | No tags attached. | ||||
2010-12-08 10:03
|
patch-1.3.4-QuitButton.txt (977 bytes)
diff -Nbaur --exclude=config.make --exclude=configure --exclude='SOGoCASSession.*' --exclude='LDAPSource.*' --exclude='SOGoUserManager.*' --exclude='*.css' --exclude='SOGoSystemDefaults.*' SOGo-1.3.4-dist/UI/Common/UIxPageFrame.m SOGo-1.3.4/UI/Common/UIxPageFrame.m
--- SOGo-1.3.4-dist/UI/Common/UIxPageFrame.m 2010-11-17 17:30:03.000000000 +0100
+++ SOGo-1.3.4/UI/Common/UIxPageFrame.m 2010-12-08 09:27:51.000000000 +0100
@@ -458,9 +466,10 @@
if ([auth respondsToSelector: @selector (cookieNameInContext:)])
{
sd = [SOGoSystemDefaults sharedSystemDefaults];
- canLogoff = (([[sd authenticationType] isEqualToString: @"cas"]
- && [sd CASLogoutEnabled])
- || [[auth cookieNameInContext: context] length] > 0);
+ if ([[sd authenticationType] isEqualToString: @"cas"])
+ canLogoff = [sd CASLogoutEnabled];
+ else
+ canLogoff = [[auth cookieNameInContext: context] length] > 0;
}
else
canLogoff = NO;
|
|
|
Dup of 0000953 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-12-08 10:03 | paubry | New Issue | |
| 2010-12-08 10:03 | paubry | File Added: patch-1.3.4-QuitButton.txt | |
| 2010-12-08 14:30 |
|
Note Added: 0001935 | |
| 2010-12-08 14:30 |
|
Status | new => closed |
| 2010-12-08 14:30 |
|
Resolution | open => duplicate |
| 2010-12-08 14:30 |
|
Relationship added | duplicate of 0000953 |
| 2012-11-06 13:10 | ludovic | Relationship added | has duplicate 0002091 |
| 2012-11-06 13:10 | ludovic | Relationship deleted | has duplicate 0002091 |
