Dependency Graph

Dependency Graph
related to related to child of child of duplicate of duplicate of

View Issue Details

IDProjectCategoryView StatusLast Update
0005635SOGo Connectorwith SOGopublic2023-03-23 09:16
Reportersebastien Assigned Tosebastien  
PriorityhighSeveritymajorReproducibilityalways
Status assignedResolutionopen 
Product Version78.0.2 
Summary0005635: Support Thunderbird 102
Description

Thunderbird 102 is not supported yet. As many of you request, a beta version is available.

Beta : https://github.com/Alinto/sogo-connector/tree/tb102

This ticket is also used to have feedback on the beta.

Steps To Reproduce

Use connector on TB 102

TagsNo tags attached.

Relationships

has duplicate 0005525 closedsebastien Connector Plugin not compatible with next Thunderbird release. (102) 

Activities

sebastien

sebastien

2022-11-01 15:46

administrator   ~0016332

Last edited: 2022-11-01 15:46

Here is the last XPI on demo.sogo.nu :

Any feedback is welcome

T.B.

T.B.

2022-11-01 19:49

reporter   ~0016334

your last commit ( https://github.com/Alinto/sogo-connector/commit/32828dd8e1fe7b4437c286569cd58008ca9f812f ) changed the error to (comparison in attachment):

Uncaught TypeError: window.arguments[0].createFolder is not a function
_confirmCreation chrome://sogo-connector/content/general/creation-overlay.js:43
onCreateButtonClick chrome://sogo-connector/content/general/creation-overlay.js:28
2 creation-overlay.js:43:25
_confirmCreation chrome://sogo-connector/content/general/creation-overlay.js:43
onCreateButtonClick chrome://sogo-connector/content/general/creation-overlay.js:28

T.B.

T.B.

2022-11-01 21:26

reporter   ~0016335

Right Mouse Button on local calendar --> Delete Calendar --> Do you really want to delete this calendar? --> Error Log: " window[this.uniqueRandomID].onLoad is not a function" --> OK --> "Uncaught TypeError: cal.getCalendarManager is not a function"

Same Error when trying to delete a Sogo calendar with wrong credentials: "https://demo.sogo.nu/SOGo/dav/WRONG_EMAIL_ADRESS/Calendar/personal/".

Maybe same Error when deleting normal Sogo Calendars. I did not try this.

T.B.

T.B.

2022-11-01 21:33

reporter   ~0016336

I've seen several other "TypeError: "x" is not a function" Errors. Was there a general change in thunderbird and mabe you can fix more of the issues when you understand the change in Thunderbird?

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Not_a_function

sebastien

sebastien

2022-11-02 09:17

administrator   ~0016337

Last edited: 2022-11-02 11:46

I also tested on TB 102.4.1 on Windows 11. Didn't get any errors with my configuration.
Here is the testing process (in video) : https://we.tl/t-kw5gofDIPI

I would like to ensure that you don't have issue with the same configuration than me.
Could you please have a try with the xpi above and the configuration in attachment ? (Mails won't be retrieved but it doesn't matter).

Use sogo3 / sogo as credentials

Note : If the useEmail option is false in connector configuration, it will use incoming server login for credentials.

EDIT : I'm confused - with Alinto's server I still didn't get any errors. Maybe you can try to delete the Thunderbird directory in %AppData% and try to reconfigure your account

sebastien

sebastien

2022-11-02 13:24

administrator   ~0016338

Good news, I could reproduced when installing module in another way than debug. I can investigate ;)

cz

cz

2022-11-07 15:43

reporter   ~0016342

Hi,

We've been testing the integrator for Thunderbird 102 with all iterations. after the latest commit (https://github.com/Alinto/sogo-connector/commit/be48784c27f1f60ebf61494814a86b9fcaebaf5f) the sogo-specific calendar buttons (New Calendar, Subscribe, Remove) are missing.
This issue is consistent across Windows and Linux Systems with Thunderbird 102.4.0-102.4.2.

Thanks for your work

sebastien

sebastien

2022-11-07 16:50

administrator   ~0016344

Hi community users,

Could you please test with the attached xpi ?

Here is some additional informations :

  • When installing the add on, if the credentials popup does not appear, please disable and reenable the add on - and report this issue in this ticket
  • When the add on is installed, restart Thunderbird

Thanks all for your feedback

Sebastien

cz

cz

2022-11-07 19:55

reporter   ~0016345

Hi,

We tested your .xpi and the buttons work.
The relevant change that fixed the issue was the update from https://github.com/thundernest/addon-developer-support/commit/30280c595585f78992581e0653cedc917f1307ff which contained changes to api/WindowListener/implementation.js and api/WindowListener/schema.json

additionally we discovered that the calendar creation dialogue reuses the messages for the address books. find attached a patch that fixes this for German and English.

Cheers

calendar_messages.patch (2,805 bytes)   
diff --git a/_locales/de-DE/messages.json b/_locales/de-DE/messages.json
index b3290d4..4160190 100644
--- a/_locales/de-DE/messages.json
+++ b/_locales/de-DE/messages.json
@@ -149,6 +149,15 @@
     "calendar.preferences.general.default-todos-classification.label": {
         "message": "Aufgabenklassifikation:"
     },
+    "calendar.creation.button.create.label": {
+        "message": "Erstellen"
+    },
+    "calendar.creation.instructions.label": {
+        "message": "Bitte geben Sie den Namen ihres neuen Kalenders ein:"
+    },
+    "calendar.creation.title": {
+        "message": "Kalender erstellen..."
+    },
     "contacts.categories": {
         "message": "Geschäftspartner,Familie,Freund,Kollegin,Konkurrenten,Kunden,Lieferant,Presse,VIP"
     },
diff --git a/_locales/en-US/messages.json b/_locales/en-US/messages.json
index 5ae649f..d0a29da 100644
--- a/_locales/en-US/messages.json
+++ b/_locales/en-US/messages.json
@@ -149,6 +149,15 @@
     "calendar.preferences.general.default-todos-classification.label": {
         "message": "Tasks classification:"
     },
+    "calendar.creation.button.create.label": {
+        "message": "Create"
+    },
+    "calendar.creation.instructions.label": {
+        "message": "Please enter the name of your new calendar:"
+    },
+    "calendar.creation.title": {
+        "message": "Calendar creation..."
+    },
     "contacts.categories": {
         "message": "Colleague,Competitor,Customer,Friend,Family,Business Partner,Provider,Press,VIP"
     },
diff --git a/chrome/content/sogo-connector/calendar/creation-dialog.xhtml b/chrome/content/sogo-connector/calendar/creation-dialog.xhtml
index 4a8d110..f483248 100644
--- a/chrome/content/sogo-connector/calendar/creation-dialog.xhtml
+++ b/chrome/content/sogo-connector/calendar/creation-dialog.xhtml
@@ -10,15 +10,15 @@ URL:           http://inverse.ca
 <?xml-stylesheet type="text/css" href="chrome://messenger/skin/input-fields.css"?>
 
 <window id="calendar-creation-window"
-        title="__MSG_creation.title__"
+        title="__MSG_calendar.creation.title__"
         xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
         xmlns:html="http://www.w3.org/1999/xhtml">
 
   <script type="application/x-javascript" src="chrome://sogo-connector/content/general/creation-overlay.js"/>
   <script type="application/x-javascript" src="chrome://sogo-connector/content/global/i18n.js"/>
     
-  <label id="creationLabel" value="__MSG_creation.instructions.label__"/>
+  <label id="creationLabel" value="__MSG_calendar.creation.instructions.label__"/>
   <html:input id="createInput"/>
-  <button id="createButton" label="__MSG_creation.button.create.label__"/>
+  <button id="createButton" label="__MSG_calendar.creation.button.create.label__"/>
   
 </window>
calendar_messages.patch (2,805 bytes)   
sebastien

sebastien

2022-11-08 07:15

administrator   ~0016346

Last edited: 2022-11-08 08:10

Hi @cz,

Thank you for your feedback and your patch.
I have pushed code on branch tb102 and add also FR translations.
As I'm not familiar with TB extension, can you confirm everything works as expected ?

Sebastien

sebastien

sebastien

2022-11-08 08:11

administrator   ~0016348

cz

cz

2022-11-08 10:27

reporter   ~0016352

Hi @smizrahi,

The connector works as expected for demo.sogo.nu. We also tested our configuration built from the git branch tb102 with the same result.
After the addon installation the credentials popup appears. A restart of Thunderbird is required for Calendar and Addressbook discovery, creating or subscribing calendars works instantly.
Thank you very much for your work!

sebastien

sebastien

2022-11-08 13:16

administrator   ~0016354

Glad to hear ! Some users also complains about carddav functionalities. I'm currently working on those problems.
Do you have issues with contacts ?

Sebastien

sebastien

sebastien

2022-11-09 14:37

administrator   ~0016362

Seems that address book is not working - it needs a complete rework on this part due to Thunderbird UI changes

cz

cz

2022-11-09 16:48

reporter   ~0016364

Sorry for the delay in our reply: Technically the addressbook is working: on startup it creates all addressbooks (and removes those deleted in the sogo web interface) and sync also works just fine. UI wise nothing works: there are no buttons and no chance to (un)subscribe any addressbook at all.
Support for vCard4 and address lists (as stated in https://bugs.sogo.nu/view.php?id=1205) is unfortunately still missing...
Thank you for your work!

SlavekB

SlavekB

2022-11-15 13:09

reporter   ~0016391

Please, can you look also at this annoying bug?
https://bugs.sogo.nu//view.php?id=5358

I assume that this causes problems to all who use characters with accents – including French. It would be great if it was possible to solve it for the new version of the extension.

cnaumer

cnaumer

2022-11-29 12:46

reporter   ~0016426

I am also testing the new connector and I see an issue that sometimes complete days are without calaendar entries.

Errors in the Logs are these:
Uncaught TypeError: cal.itip.getInvitedAttendee(...) is null
setCSSClasses chrome://calendar/content/calendar-editable-item.js:396
set occurrence chrome://calendar/content/calendar-editable-item.js:204
relayout chrome://calendar/content/calendar-multiday-view.js:465
mEventMapTimeout chrome://calendar/content/calendar-multiday-view.js:386
calendar-editable-item.js:396:20
setCSSClasses chrome://calendar/content/calendar-editable-item.js:396
set occurrence chrome://calendar/content/calendar-editable-item.js:204
relayout chrome://calendar/content/calendar-multiday-view.js:465
mEventMapTimeout chrome://calendar/content/calendar-multiday-view.js:386

I know that this is actually Thunderbird code but this only happens when the Plugin is installed. I think it has something to do with the ACL-Hooks that where implemented in Thunderbird. I filed a Bug against TB (https://bugzilla.mozilla.org/show_bug.cgi?id=1741801) but that didn't get much attention. All the info is there in the bug report.

sebastien

sebastien

2022-11-29 13:01

administrator   ~0016427

Thanks everybody for reporting. There is breaking changes introduced in TB 102, it will probably need a deep rework of the current code so it will not be available quickly.
I keep this ticket opened to inform updates / changes.

cz

cz

2023-03-23 09:16

reporter   ~0016757

Someone found a fix for the "empty days" issue:

https://bugs.sogo.nu/view.php?id=5711#c16756

Issue History

Date Modified Username Field Change
2022-11-01 15:45 sebastien New Issue
2022-11-01 15:45 sebastien Status new => assigned
2022-11-01 15:45 sebastien Assigned To => sebastien
2022-11-01 15:45 sebastien Status assigned => acknowledged
2022-11-01 15:45 sebastien Status acknowledged => assigned
2022-11-01 15:46 sebastien Note Added: 0016332
2022-11-01 15:46 sebastien File Added: sogo-connector-102.0.0-a1271e9704.xpi
2022-11-01 15:46 sebastien Note Edited: 0016332
2022-11-01 19:49 T.B. Note Added: 0016334
2022-11-01 19:49 T.B. File Added: Thunderbird 102.4.0 Sogo Connector 102.Beta_02.png
2022-11-01 21:26 T.B. Note Added: 0016335
2022-11-01 21:26 T.B. File Added: Thunderbird 102.4.0 Sogo Connector 102.Beta_04.png
2022-11-01 21:26 T.B. File Added: Thunderbird 102.4.0 Sogo Connector 102.Beta_05.png
2022-11-01 21:33 T.B. Note Added: 0016336
2022-11-02 09:17 sebastien Note Added: 0016337
2022-11-02 09:17 sebastien File Added: Capture d’écran 2022-11-02 à 10.05.53.png
2022-11-02 10:28 sebastien Note Edited: 0016337
2022-11-02 11:46 sebastien Note Edited: 0016337
2022-11-02 13:24 sebastien Note Added: 0016338
2022-11-07 15:43 cz Note Added: 0016342
2022-11-07 16:50 sebastien Note Added: 0016344
2022-11-07 16:50 sebastien File Added: sogo-connector-102.0.0-be48784c27.xpi
2022-11-07 19:55 cz Note Added: 0016345
2022-11-07 19:55 cz File Added: calendar_messages.patch
2022-11-08 07:15 sebastien Note Added: 0016346
2022-11-08 08:10 sebastien Note Edited: 0016346
2022-11-08 08:11 sebastien Note Added: 0016348
2022-11-08 08:11 sebastien File Added: sogo-connector-102.0.0-14885057c1.xpi
2022-11-08 10:27 cz Note Added: 0016352
2022-11-08 13:16 sebastien Note Added: 0016354
2022-11-09 14:37 sebastien Note Added: 0016362
2022-11-09 16:48 cz Note Added: 0016364
2022-11-15 13:09 SlavekB Note Added: 0016391
2022-11-28 14:46 sebastien Relationship added has duplicate 0005525
2022-11-29 12:46 cnaumer Note Added: 0016426
2022-11-29 13:01 sebastien Note Added: 0016427
2023-03-23 09:16 cz Note Added: 0016757