View Issue Details

IDProjectCategoryView StatusLast Update
0000764SOGoBackend Calendarpublic2010-08-20 15:24
ReporterMarcel Assigned To 
PrioritynormalSeveritytrivialReproducibilityalways
Status newResolutionopen 
Product Version1.3.1 
Summary0000764: .ics exports lack a final newline
Description

When having to postprocess WebDAV ICS files retrieved from SOGo, the lack of the final newline after END:VCALENDAR can cause some confusion. Please append this newline.

TagsNo tags attached.

Activities

wsourdeau

wsourdeau

2010-08-20 14:33

viewer   ~0001320

What do you mean by "some confusion". The format used is perfectly valid...

Marcel

Marcel

2010-08-20 15:24

reporter   ~0001323

The format is perfectly valid, no doubt. Many line-based tools however do

  1. complain about incomplete last lines (diff and related tools, editors such as vi),
  2. will make things harder to read ("cat" on the file will interfere with the next shell prompt),
  3. will do something wrong (some regular expressions, perl's chop),
  4. silently append that newline (sed, grep, vi, …),
  5. which in turn makes it hard for diff and related tools (including version management software) to see whether anything has changed at all.

Unless there is a reason against having this terminal newline (besides saving one byte in network transmissions), I think adding that newline at the appropriate place in the code is less work than actually reading my arguments :-)

Issue History

Date Modified Username Field Change
2010-08-20 13:41 Marcel New Issue
2010-08-20 14:33 wsourdeau Note Added: 0001320
2010-08-20 15:24 Marcel Note Added: 0001323