View Issue Details

IDProjectCategoryView StatusLast Update
0005935SOGosogo-toolpublic2024-03-01 13:52
Reporterbuzzdee Assigned Tosebastien  
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version5.10.0 
Fixed in Version5.11.0 
Summary0005935: build failure in SOGoToolUpdateSecret.m
Description

cc SOGoToolUpdateSecret.m -c \
-MMD -MP -I/usr/local/include/gnustep -DMFA_CONFIG=1 -DSOGO_MAJOR_VERSION=5 -DSOGO_MINOR_VERSION=10 -DSOGO_SUBMINOR_VERSION=0 -DSOGO_LIBDIR="@\"/usr/local/lib/GNUstep/SOGo\"" -DGNUSTEP -DGNUSTEP_BASE_LIBRARY=1 -DGNUSTEP_RUNTIME=1 -D_NONFRAGILE_ABI=1 -DGNUSTEP_BASE_LIBRARY=1 -fno-strict-aliasing -fexceptions -fobjc-exceptions -D_NATIVE_OBJC_EXCEPTIONS -pthread -fPIC -DDEBUG -fno-omit-frame-pointer -Wall -DGSWARN -DGSDIAGNOSE -Wno-import -O2 -pipe -g -O0 -fobjc-runtime=gnustep-1.8 -fblocks -O0 -g -frecord-gcc-switches -fconstant-string-class=NSConstantString -D_GNU_SOURCE -I../SOPE/ -I../SoObjects/ -I. -I/sogo-5.10.0_writes_to_HOME/GNUstep/Library/Headers -I/usr/local/include -I/usr/local/include \
-o obj/sogo-tool.obj/SOGoToolUpdateSecret.m.o
SOGoToolUpdateSecret.m:132:37: warning: instance method '-gcsTableName' not found (return type defaults to 'id') [-Wobjc-method-access]
[userProfileUrl gcsTableName]];
^~~~
/usr/local/include/Foundation/NSURL.h:72:12: note: receiver is instance of class declared here
@interface NSURL: NSObject <NSCoding, NSCopying, NSURLHandleClient>
^
SOGoToolUpdateSecret.m:97:22: warning: unused variable 'pool' [-Wunused-variable]
NSAutoreleasePool *pool;
^
SOGoToolUpdateSecret.m:102:6: warning: unused variable 'allUsers' [-Wunused-variable]
id allUsers;
^
SOGoToolUpdateSecret.m:103:7: warning: unused variable 'count' [-Wunused-variable]
int count, max;
^
SOGoToolUpdateSecret.m:193:35: warning: instance method '-encryptAES256GCM:exception:' not found (return type defaults to 'id') [-Wobjc-method-access]
newPassword = [password encryptAES256GCM: secret exception:&exception];
^~~~~~~~~~
/usr/local/include/Foundation/NSString.h:284:12: note: receiver is instance of class declared here
@interface NSString :NSObject <NSCoding, NSCopying, NSMutableCopying>
^
SOGoToolUpdateSecret.m:197:22: warning: 'NSDictionary' may not respond to 'setObject:forKey:'
[account setObject: newPassword forKey: @"password"];


SOGoToolUpdateSecret.m:250:43: warning: instance method '-decryptAES256GCM:iv:tag:exception:' not found (return type defaults to 'id') [-Wobjc-method-access]
            decryptedPassword = [password decryptAES256GCM: oldSecret iv: iv tag: tag exception:&exception];
                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/include/Foundation/NSString.h:284:12: note: receiver is instance of class declared here
@interface NSString :NSObject &lt;NSCoding, NSCopying, NSMutableCopying>
           ^
SOGoToolUpdateSecret.m:251:52: warning: instance method '-encryptAES256GCM:exception:' not found (return type defaults to 'id') [-Wobjc-method-access]
            encryptedPassword = [decryptedPassword encryptAES256GCM: newSecret exception:&exception];
                                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/include/Foundation/NSString.h:284:12: note: receiver is instance of class declared here
@interface NSString :NSObject &lt;NSCoding, NSCopying, NSMutableCopying>
           ^
SOGoToolUpdateSecret.m:260:22: warning: 'NSDictionary' may not respond to 'setObject:forKey:'
            [account setObject: encryptedPassword forKey: @&quot;password&quot;];
             ~~~~~~~ ^
SOGoToolUpdateSecret.m:270:3: error: void method 'updateSecretFromEncryptedData:oldSecret:' should not return a value [-Wreturn-type]
  return rc;
  ^      ~~
SOGoToolUpdateSecret.m:312:37: warning: instance method '-decryptAES256GCM:iv:tag:exception:' not found (return type defaults to 'id') [-Wobjc-method-access]
            newPassword = [password decryptAES256GCM: oldSecret iv: iv tag: tag exception:&exception];
                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/include/Foundation/NSString.h:284:12: note: receiver is instance of class declared here
@interface NSString :NSObject &lt;NSCoding, NSCopying, NSMutableCopying>
           ^
SOGoToolUpdateSecret.m:316:24: warning: 'NSDictionary' may not respond to 'setObject:forKey:'
              [account setObject: newPassword forKey: @&quot;password&quot;];
               ~~~~~~~ ^
SOGoToolUpdateSecret.m:390:12: warning: unused variable 'i' [-Wunused-variable]
  int max, i;
           ^
12 warnings and 1 error generated.
Additional Information

besides the error, the amount of warnings also don't look good.

this is an older OpenBSD 7.0 amd64, clang 11.1.0

TagsNo tags attached.

Activities

buzzdee

buzzdee

2024-03-01 12:46

reporter   ~0017612

removing the
return rc;
line let's it properly build.

sebastien

sebastien

2024-03-01 13:52

administrator   ~0017614

Fixed in https://github.com/Alinto/sogo/commit/cc061582f49a97dc269eadb2b8df98a8bf078afd

Sebastien

Issue History

Date Modified Username Field Change
2024-03-01 12:42 buzzdee New Issue
2024-03-01 12:46 buzzdee Note Added: 0017612
2024-03-01 13:52 sebastien Note Added: 0017614
2024-03-01 13:52 sebastien Assigned To => sebastien
2024-03-01 13:52 sebastien Status new => resolved
2024-03-01 13:52 sebastien Resolution open => fixed
2024-03-01 13:52 sebastien Fixed in Version => 5.11.0