View Issue Details

IDProjectCategoryView StatusLast Update
0005845SOGowith SOGopublic2023-08-25 07:04
Reporterbuzzdee Assigned Tosebastien  
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version5.8.4 
Fixed in Version5.9.0 
Summary0005845: tried to upgrade from 5.8.0 -> 5.8.4 buiding SOGo fails with error in SOGoGCSFolder.m
Description

cc SOGoGCSFolder.m -c \
-MMD -MP -I/usr/local/include/gnustep -DMFA_CONFIG=1 -DSOGO_BUILD_DATE="@\"@unimatrix.l00-bugdead-prods.de 202308212121\"" -DSOGO_LIBDIR="\"/usr/local/lib/GNUstep/SOGo\"" -DSOGO_MAJOR_VERSION="@\"5\"" -DSOGO_MINOR_VERSION="@\"8\"" -DSOGO_SUBMINOR_VERSION="@\"4\"" -DHAVE_OPENSSL=1 -DHAVE_SODIUM=1 pkg-config --cflags libsodium -DGNUSTEP -DGNUSTEP_BASE_LIBRARY=1 -DGNUSTEP_RUNTIME=1 -D_NONFRAGILE_ABI=1 -DGNUSTEP_BASE_LIBRARY=1 -fno-strict-aliasing -fexceptions -fobjc-exceptions -D_NATIVE_OBJC_EXCEPTIONS -pthread -fPIC -DDEBUG -fno-omit-frame-pointer -Wall -DGSWARN -DGSDIAGNOSE -Wno-import -O2 -pipe -g -O0 -fobjc-runtime=gnustep-1.8 -fblocks -O0 -g -frecord-gcc-switches -fconstant-string-class=NSConstantString -I../../SOPE/ -I.. -I../../UI -I./derived_src -I. -I/sogo-5.8.4_writes_to_HOME/GNUstep/Library/Headers -I/usr/local/include -I/usr/local/include \
-o obj/SOGo.obj/SOGoGCSFolder.m.o
SOGoGCSFolder.m:657:2: warning: GDLContentStore should provide methods for renaming folders [-W#warnings]
#warning GDLContentStore should provide methods for renaming folders
^
SOGoGCSFolder.m:685:2: warning: SOGoFolder should have the corresponding method [-W#warnings]
#warning SOGoFolder should have the corresponding method
^
SOGoGCSFolder.m:1451:2: warning: review this when fixing http://www.scalableogo.org/bugs/view.php?id=276 [-W#warnings]
#warning review this when fixing http://www.scalableogo.org/bugs/view.php?id=276
^
SOGoGCSFolder.m:1946:2: warning: this should be checked [-W#warnings]
#warning this should be checked
^
SOGoGCSFolder.m:2122:2: warning: the two following methods should be replaced with the new dav rendering mechanism [-W#warnings]
#warning the two following methods should be replaced with the new dav rendering mechanism
^
SOGoGCSFolder.m:2256:2: warning: We need to use the new DAV utilities here... [-W#warnings]
#warning We need to use the new DAV utilities here...
^
SOGoGCSFolder.m:2257:2: warning: this is baddddd because we return a single-valued dictionary containing a cname which may not event exist... the logic behind appendObject:... should be rethought, especially since we may start using SQL views [-W#warnings]
#warning this is baddddd because we return a single-valued dictionary containing \
^
SOGoGCSFolder.m:2309:2: warning: review this when bug 0000276 [-W#warnings]
#warning review this when bug 0000276
^
SOGoGCSFolder.m:153:17: error: instance variable 'context' accessed in class method
ocsName = [[context request] isMacOSXVenturaCalendarApp] ? @"Personal" : @"personal";
^
SOGoGCSFolder.m:407:26: warning: instance method '-isMacOSXVenturaCalendarApp' not found (return type defaults to 'id') [-Wobjc-method-access]
if ([[context request] isMacOSXVenturaCalendarApp]) {
^~~~~~
/usr/local/include/NGObjWeb/WORequest.h:42:12: note: receiver is instance of class declared here
@interface WORequest : WOMessage
^
SOGoGCSFolder.m:444:26: warning: instance method '-isMacOSXVenturaCalendarApp' not found (return type defaults to 'id') [-Wobjc-method-access]
if ([[context request] isMacOSXVenturaCalendarApp]) {
^~~~~~
/usr/local/include/NGObjWeb/WORequest.h:42:12: note: receiver is instance of class declared here
@interface WORequest : WOMessage
^
SOGoGCSFolder.m:460:32: warning: instance method '-folderForRecord:' not found (return type defaults to 'id') [-Wobjc-method-access]
return [[self folderManager] folderForRecord: record];
^~~~~~~
/usr/local/include/GDLContentStore/GCSFolderManager.h:36:12: note: receiver is instance of class declared here
@interface GCSFolderManager : NSObject
^
SOGoGCSFolder.m:477:26: warning: instance method '-isMacOSXVenturaCalendarApp' not found (return type defaults to 'id') [-Wobjc-method-access]
if ([[context request] isMacOSXVenturaCalendarApp]) {
^~~~~~
/usr/local/include/NGObjWeb/WORequest.h:42:12: note: receiver is instance of class declared here
@interface WORequest : WOMessage
^
SOGoGCSFolder.m:988:18: warning: incompatible pointer types assigning to 'NSMutableArray ' from 'NSArray ' [-Wincompatible-pointer-types]
allUsers = [NSArray arrayWithObject: sogoUser];
^ ~~~~~~~
/usr/local/include/Foundation/NSArray.h:70:1: note: class method 'arrayWithObject:' is assumed to return an instance of its receiver type ('NSArray *')

  • (instancetype) arrayWithObject: (id)anObject;
    ^
    SOGoGCSFolder.m:990:11: warning: incompatible pointer types assigning to 'NSMutableArray ' from 'NSArray ' [-Wincompatible-pointer-types]
    allUsers = [NSArray array];
    ^ ~~~
    /usr/local/include/Foundation/NSArray.h:64:1: note: class method 'array' is assumed to return an instance of its receiver type ('NSArray *')
  • (instancetype) array;
    ^
    14 warnings and 1 error generated.
    gmake[4]: [/usr/local/share/GNUstep/Makefiles/rules.make:521: obj/SOGo.obj/SOGoGCSFolder.m.o] Error 1
    gmake[3]:
    [/usr/local/share/GNUstep/Makefiles/Instance/framework.make:612: internal-framework-run-compile-submake] Error 2
    gmake[2]: [/usr/local/share/GNUstep/Makefiles/Master/rules.make:297: SOGo.all.framework.variables] Error 2
    gmake[2]: Leaving directory '/home/ports/pobj/amd64/sogo-5.8.4/SOGo-5.8.4/SoObjects/SOGo'
    gmake[1]:
    [/usr/local/share/GNUstep/Makefiles/Master/serial-subdirectories.make:53: internal-all] Error 2
    gmake[1]: Leaving directory '/home/ports/pobj/amd64/sogo-5.8.4/SOGo-5.8.4/SoObjects'
    gmake: [/usr/local/share/GNUstep/Makefiles/Master/serial-subdirectories.make:53: internal-all] Error 2
    Error 2 in . (/home/ports/infrastructure/mk/bsd.port.mk:2961 '/home/ports/pobj/amd64/sogo-5.8.4/.build_done': @cd /home/ports/pobj/amd64...)
    *** Error 2 in /home/ports/www/sogo (/home/ports/infrastructure/mk/bsd.port.mk:2607 'all': @lock=sogo-5.8.4; export _LOCKS_HELD=" sogo-5.8....)
Steps To Reproduce

going to try to reproduce on a recent snapshot as soon as possible.

Additional Information

happens always to me. This is an older OpenBSD 7.0, amd64
gnustep-base-1.28.0p2 GNUstep base library
gnustep-libobjc2-1.8.1p4 GNUstep libobjc2 objective-c runtime
gnustep-make-2.9.0 GNUstep makefile package

clang -v
OpenBSD clang version 11.1.0
Target: amd64-unknown-openbsd7.0
Thread model: posix
InstalledDir: /usr/bin

TagsNo tags attached.

Activities

sebastien

sebastien

2023-08-22 16:17

administrator   ~0017218

This code has been removed in https://github.com/Alinto/sogo/commit/4f7c73143f38b1e7e00a51b9457b55ce609a02a9

Please try with updated sources

Sebastien

buzzdee

buzzdee

2023-08-23 20:13

reporter   ~0017221

Sebastien

the whole patch didn't apply cleanly to the 5.8.4 sources, so I manually applied just only the changes to SOGoGCSFolder.m
With that, SOGo builds fine, packages and runs, for the few minutes I tested.

have to test a bit more, but with that, I think I can update the OpenBSD SOGo packages.

thanks for the quick turnaround!
Sebastian

Issue History

Date Modified Username Field Change
2023-08-21 19:34 buzzdee New Issue
2023-08-22 16:17 sebastien Note Added: 0017218
2023-08-22 16:18 sebastien Assigned To => sebastien
2023-08-22 16:18 sebastien Status new => feedback
2023-08-23 20:13 buzzdee Note Added: 0017221
2023-08-23 20:13 buzzdee Status feedback => assigned
2023-08-25 07:04 sebastien Status assigned => resolved
2023-08-25 07:04 sebastien Resolution open => fixed
2023-08-25 07:04 sebastien Fixed in Version => 5.9.0