View Issue Details

IDProjectCategoryView StatusLast Update
0004909SOGo ConnectorGUIpublic2020-03-04 16:44
ReporterMartinL Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status newResolutionopen 
Summary0004909: A category is always assigned to contact with sogo-connector 68.0.0
Description

In TB68 the combo-box to select the contact categories in contact dialog has been replaced by a simple menu list.
When creating a new or editing an existing contact without any category, the first category of the list is added when saving.
It would be nice to have a choice "none" in the menu list selected by default.

TagsNo tags attached.

Activities

MartinL

MartinL

2019-12-19 14:16

reporter   ~0014001

Here is a patch to add an empty item in category menu list:

From 9c2e6b6ec1b7a9b7d703ead1ff3b1ef1c106f9e7 Mon Sep 17 00:00:00 2001
Message-Id: <9c2e6b6ec1b7a9b7d703ead1ff3b1ef1c106f9e7.1576761586.git.martin.leusch@imrcom.fr>
From: Martin LEUSCH <martin.leusch@imrcom.fr>
Date: Thu, 19 Dec 2019 14:19:36 +0100
Subject: [PATCH] Add an empty item in category menu list


.../content/sogo-connector/addressbook/common-card-overlay.js | 3 +++
1 file changed, 3 insertions(+)

diff --git a/chrome/content/sogo-connector/addressbook/common-card-overlay.js b/chrome/content/sogo-connector/addressbook/common-card-overlay.js
index cc72457..6f1bc38 100644
--- a/chrome/content/sogo-connector/addressbook/common-card-overlay.js
+++ b/chrome/content/sogo-connector/addressbook/common-card-overlay.js
@@ -114,6 +114,9 @@ function SCResetCategoriesMenu(menu, catValue) {
//}
menu.removeAllItems();

  • // Add an empty item to menu for no category
  • let itemNone = menu.appendItem("");
  • //let menuPopup = document.createElement("menupopup");
    for (let catName of gSCCardValues.categories) {
    //let item = document.createElement("menuitem");
    --
    2.24.0

ps: I had an error by trying to upload the patch file as attachment.

Issue History

Date Modified Username Field Change
2019-12-17 16:01 MartinL New Issue
2019-12-19 14:16 MartinL Note Added: 0014001