View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0003579 | SOGo | Web Address Book | public | 2016-03-12 09:06 | 2016-04-06 02:07 |
Reporter | tfu | Assigned To | ludovic | ||
Priority | normal | Severity | major | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Platform | [Client] Microsoft | OS | Windows | OS Version | 7 |
Product Version | 3.0.2 | ||||
Fixed in Version | 3.1.0 | ||||
Summary | 0003579: Birthday is saved 1 day in the past into the vcard | ||||
Description | 01-jan-2003 is saved as BDAY:20021231. The WebUI shows this as 01-jan-2003. | ||||
Steps To Reproduce | Create a new contact and set the birthday to 01-jan-2003. The contact's vcard look like this: BEGIN:VCARD | ||||
Tags | No tags attached. | ||||
http://demo.sogo.nu/SOGo seems to be currently on version 3.0.1 (according to what is shown in preferences). |
|
On my env I can reproduce the problem if I set the birthday to a date between e.g. 25-sep-83 and 30-oct-83 or 30-sep-05 and 27-oct-85. Dates between these sample dates results in a BDAY one day earlier. User's timezone: Europe/London |
|
The reproducibility of the problem depends the timezone setting of. e.g.: Setting the birthday to 2016-03-13: date = [NSCalendarDate dateWithTimeIntervalSince1970: seconds]; to this date: 2016-03-13 00:00:00 +0100 The resulting value for BDAY is 20160313. -> OK Setting the birthday to 1985-10-26: date = [NSCalendarDate dateWithTimeIntervalSince1970: seconds]; to this date: 1985-10-25 23:00:00 +0100 The resulting value for BDAY is 19851025. -> Wrong I hope this finding helps to fix the problem. == Another timezone related issue might be in NGVCard+SOGo.m->birthday: I think to have consistent results this should be changed from
to
This should give a consistent result which is not influenced by set setting in SOGoTimeZone. |
|
sogo: master 85cacd97 2016-03-13 13:44 Details Diff |
Use GMT tz when setting birthday (fixes 0003579) |
Affected Issues 0003579 |
|
mod - SoObjects/Contacts/NGVCard+SOGo.m | Diff File | ||
sogo: v2 20b1d3c0 2016-03-13 13:44 Details Diff |
Use GMT tz when setting birthday (fixes 0003579) |
Affected Issues 0003579 |
|
mod - SoObjects/Contacts/NGVCard+SOGo.m | Diff File | ||
sogo: master bfd69d3f 2016-04-05 22:03 Details Diff |
Improve handling of a contact's birthday Fixes 0003579 |
Affected Issues 0003579 |
|
mod - UI/Contacts/UIxContactEditor.m | Diff File | ||
mod - UI/Contacts/UIxContactView.m | Diff File | ||
mod - UI/WebServerResources/js/Contacts/Card.service.js | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2016-03-12 09:06 | tfu | New Issue | |
2016-03-12 15:04 | tfu | Note Added: 0009731 | |
2016-03-12 15:48 | tfu | Note Added: 0009732 | |
2016-03-13 14:33 | tfu | Note Added: 0009735 | |
2016-03-13 17:45 | ludovic | Changeset attached | => sogo master 85cacd97 |
2016-03-13 17:45 | ludovic | Assigned To | => ludovic |
2016-03-13 17:45 | ludovic | Resolution | open => fixed |
2016-03-13 17:47 | ludovic | Changeset attached | => sogo v2 20b1d3c0 |
2016-03-13 17:48 | ludovic | Status | new => resolved |
2016-03-13 17:48 | ludovic | Fixed in Version | => 3.1.0 |
2016-04-06 02:07 | francis | Changeset attached | => sogo master bfd69d3f |