Changesets: sogo

v2 359da78d

2016-01-23 19:10

Enrique J. Hernández Blasco


Details Diff
oc-calendar: Fix typo setting or operator

For PidLidAppointmentTimeZoneDefinitionStartDisplay.

It is a typo introduced by 376e717.
mod - OpenChange/MAPIStoreAppointmentWrapper.m Diff File

v2 5ba47678

2016-01-23 14:43

ethoms


Details Diff
fix (revised) for issue with CardDAV sync with the DAVDroid sync client.

This is a revised fix for the issue raiased in sogo bug tracker 3370 and 3373. It supercedes the fix in commit 2c723070c69899055b456119f6e8f42c279d0c57 .

The fix was noted in NEWS with the comment "we now return all cards when we receive an empty addressbook-query REPORT". However it did not work for me and at least two others, as can be seen in the commit comments. In summary, only contacts with email addresses were synced. The suggested change from kwirk fixes the regular address book sync, but it completely breaks syncing of the read-only Group Directory (Corporate Directory). My suggested changes work in full (as far as I'm able to test).

I have done some fairly extensive testing of CardDAV sync (with DAVDroid only) and it seems to work 100% now. In addition to the obvious tests, I have tested with contacts that only have one field of data entered. The feilds I've tested (with all other fields empty) are as follows:

First name
Last name
Display name
email address
Work (telephone)
Home (telephone)
Fax (telephone)
Mobile (telephone)

Additionally, I tested syncing of a contact with only the Work Address fully populated. In the webmail, since the name fields are all missing, the "Organization" field of the Work Address takes the place of the name field in the 'Name' column. This does get synced to my phone and it also appears my Android contact list with 'Name' set to the 'Organization' field data. The address, organization and website fields being in tact also.

In addition, I tested a Group Directory (Corporate Directory) [SOGoUserSources->isAddressBook] sync. It seems contacts without email addresses do not sync. This seems to be the behaviour across the board with a "." search filter. This happens despite the filter in SOGoUserSources including ldap entries without a mail attribute. Nothing I can do to patch this in SOGoFolder+CardDAV.m, that would have to be fixed in the code that deals with the special "." search filter (I guess).

I think the contact search system needs some looking into, particularly the "." search filter behaviour. There is another bug related to contact search in the webmail address book view. I will make a bug report on that soon. It's a shame there isn't an "all" search filter, it would seem it would make various parts of SOGo easier to get the right behaviour.
mod - SoObjects/Contacts/SOGoFolder+CardDAV.m Diff File

master 99765aae

2016-01-23 14:43

ethoms

Committer: Ludovic Marcotte


Details Diff
fix (revised) for issue with CardDAV sync with the DAVDroid sync client.

This is a revised fix for the issue raiased in sogo bug tracker 3370 and 3373. It supercedes the fix in commit 2c723070c69899055b456119f6e8f42c279d0c57 .

The fix was noted in NEWS with the comment "we now return all cards when we receive an empty addressbook-query REPORT". However it did not work for me and at least two others, as can be seen in the commit comments. In summary, only contacts with email addresses were synced. The suggested change from kwirk fixes the regular address book sync, but it completely breaks syncing of the read-only Group Directory (Corporate Directory). My suggested changes work in full (as far as I'm able to test).

I have done some fairly extensive testing of CardDAV sync (with DAVDroid only) and it seems to work 100% now. In addition to the obvious tests, I have tested with contacts that only have one field of data entered. The feilds I've tested (with all other fields empty) are as follows:

First name
Last name
Display name
email address
Work (telephone)
Home (telephone)
Fax (telephone)
Mobile (telephone)

Additionally, I tested syncing of a contact with only the Work Address fully populated. In the webmail, since the name fields are all missing, the "Organization" field of the Work Address takes the place of the name field in the 'Name' column. This does get synced to my phone and it also appears my Android contact list with 'Name' set to the 'Organization' field data. The address, organization and website fields being in tact also.

In addition, I tested a Group Directory (Corporate Directory) [SOGoUserSources->isAddressBook] sync. It seems contacts without email addresses do not sync. This seems to be the behaviour across the board with a "." search filter. This happens despite the filter in SOGoUserSources including ldap entries without a mail attribute. Nothing I can do to patch this in SOGoFolder+CardDAV.m, that would have to be fixed in the code that deals with the special "." search filter (I guess).

I think the contact search system needs some looking into, particularly the "." search filter behaviour. There is another bug related to contact search in the webmail address book view. I will make a bug report on that soon. It's a shame there isn't an "all" search filter, it would seem it would make various parts of SOGo easier to get the right behaviour.
mod - SoObjects/Contacts/SOGoFolder+CardDAV.m Diff File

master 3c005919

2016-01-22 20:30

Ludovic Marcotte


Details Diff
(fix) rewrote the string sanitization to be 32-bit Unicode safe
mod - NEWS Diff File
mod - SoObjects/SOGo/NSString+Utilities.m Diff File

v2 49d5a72d

2016-01-22 20:30

ludovic


Details Diff
(fix) rewrote the string sanitization to be 32-bit Unicode safe
mod - NEWS Diff File
mod - SoObjects/SOGo/NSString+Utilities.m Diff File

v2 f34aa299

2016-01-22 14:02

ludovic


Details Diff
(fix) more fix regarding recurrence exceptions and body tags
mod - ActiveSync/iCalEvent+ActiveSync.m Diff File

master 81f13404

2016-01-22 14:02

Ludovic Marcotte


Details Diff
(fix) more fix regarding recurrence exceptions and body tags

Conflicts:

ActiveSync/iCalEvent+ActiveSync.m
mod - ActiveSync/iCalEvent+ActiveSync.m Diff File

master 88207d27

2016-01-22 13:35

Ludovic Marcotte


Details Diff
(fix) now always generate invitation updates when using EAS

Conflicts:

NEWS
mod - ActiveSync/SOGoActiveSyncDispatcher+Sync.m Diff File
mod - ActiveSync/iCalEvent+ActiveSync.h Diff File
mod - ActiveSync/iCalEvent+ActiveSync.m Diff File
mod - NEWS Diff File

v2 5686e086

2016-01-22 13:35

ludovic


Details Diff
(fix) now always generate invitation updates when using EAS
mod - ActiveSync/SOGoActiveSyncDispatcher+Sync.m Diff File
mod - ActiveSync/iCalEvent+ActiveSync.h Diff File
mod - ActiveSync/iCalEvent+ActiveSync.m Diff File
mod - NEWS Diff File

v2 ed9ec046

2016-01-22 12:37

ludovic


Details Diff
(fix) make sure we escape control chars
mod - ActiveSync/NSString+ActiveSync.m Diff File

master 9ba7425e

2016-01-22 12:37

Ludovic Marcotte


Details Diff
(fix) make sure we escape control chars
mod - ActiveSync/NSString+ActiveSync.m Diff File

v2 737d2ffc

2016-01-22 10:32

ludovic


Details Diff
(feat) UI for previously commited new feature (junk/not junk)
mod - UI/MailerUI/Toolbars/SOGoMailFolder.toolbar Diff File
mod - UI/MailerUI/Toolbars/SOGoMailObject.toolbar Diff File
mod - UI/Templates/MailerUI/UIxMailMainFrame.wox Diff File
mod - UI/Templates/MailerUI/UIxMailPopupView.wox Diff File
mod - UI/WebServerResources/MailerUI.js Diff File
mod - UI/WebServerResources/MailerUIdTree.js Diff File
mod - UI/WebServerResources/UIxMailPopupView.js Diff File

v2 7ca66b40

2016-01-22 10:30

ludovic


Details Diff
(feat) new junk/not junk capability with generic SMTP integration
mod - Documentation/SOGoInstallationGuide.asciidoc Diff File
mod - NEWS Diff File
mod - SoObjects/Mailer/GNUmakefile Diff File
add - SoObjects/Mailer/SOGoJunkFolder.h Diff File
add - SoObjects/Mailer/SOGoJunkFolder.m Diff File
mod - SoObjects/Mailer/SOGoMailAccount.h Diff File
mod - SoObjects/Mailer/SOGoMailAccount.m Diff File
mod - SoObjects/Mailer/SOGoMailBaseObject.h Diff File
mod - SoObjects/Mailer/SOGoMailFolder.h Diff File
mod - SoObjects/Mailer/SOGoMailFolder.m Diff File
mod - SoObjects/Mailer/SOGoTrashFolder.h Diff File
mod - SoObjects/Mailer/SOGoTrashFolder.m Diff File
mod - SoObjects/SOGo/SOGoDefaults.plist Diff File
mod - SoObjects/SOGo/SOGoDomainDefaults.h Diff File
mod - SoObjects/SOGo/SOGoDomainDefaults.m Diff File
mod - SoObjects/SOGo/SOGoUser.m Diff File
mod - SoObjects/SOGo/SOGoUserDefaults.h Diff File
mod - SoObjects/SOGo/SOGoUserDefaults.m Diff File
mod - UI/MailerUI/English.lproj/Localizable.strings Diff File
mod - UI/MailerUI/UIxMailFolderActions.h Diff File
mod - UI/MailerUI/UIxMailFolderActions.m Diff File
mod - UI/MailerUI/product.plist Diff File

master 30377c0f

2016-01-22 10:30

Ludovic Marcotte


Details Diff
(feat) new junk/not junk capability with generic SMTP integration

Conflicts:

NEWS
SoObjects/Mailer/SOGoMailAccount.m
SoObjects/SOGo/SOGoDefaults.plist
SoObjects/SOGo/SOGoUser.m
UI/MailerUI/UIxMailFolderActions.h
UI/MailerUI/UIxMailFolderActions.m
UI/MailerUI/product.plist
mod - Documentation/SOGoInstallationGuide.asciidoc Diff File
mod - SoObjects/Mailer/GNUmakefile Diff File
add - SoObjects/Mailer/SOGoJunkFolder.h Diff File
add - SoObjects/Mailer/SOGoJunkFolder.m Diff File
mod - SoObjects/Mailer/SOGoMailAccount.h Diff File
mod - SoObjects/Mailer/SOGoMailAccount.m Diff File
mod - SoObjects/Mailer/SOGoMailBaseObject.h Diff File
mod - SoObjects/Mailer/SOGoMailFolder.h Diff File
mod - SoObjects/Mailer/SOGoMailFolder.m Diff File
mod - SoObjects/Mailer/SOGoTrashFolder.h Diff File
mod - SoObjects/Mailer/SOGoTrashFolder.m Diff File
mod - SoObjects/SOGo/SOGoDefaults.plist Diff File
mod - SoObjects/SOGo/SOGoDomainDefaults.h Diff File
mod - SoObjects/SOGo/SOGoDomainDefaults.m Diff File
mod - SoObjects/SOGo/SOGoUser.m Diff File
mod - SoObjects/SOGo/SOGoUserDefaults.h Diff File
mod - SoObjects/SOGo/SOGoUserDefaults.m Diff File
mod - UI/MailerUI/English.lproj/Localizable.strings Diff File
mod - UI/MailerUI/UIxMailFolderActions.h Diff File
mod - UI/MailerUI/UIxMailFolderActions.m Diff File
mod - UI/MailerUI/product.plist Diff File

master f1873edf

2016-01-21 20:46

Francis Lachapelle


Details Diff
(js) Display event ghost block start/end hours
mod - UI/WebServerResources/js/Scheduler/Scheduler.app.js Diff File
mod - UI/WebServerResources/js/Scheduler/sgCalendarDayBlock.directive.js Diff File
mod - UI/WebServerResources/js/Scheduler/sgCalendarGhost.directive.js Diff File
mod - UI/WebServerResources/js/Scheduler/sgDraggableCalendarBlock.directive.js Diff File
mod - UI/WebServerResources/scss/views/SchedulerUI.scss Diff File

master 54100c1f

2016-01-21 15:00

Francis Lachapelle


Details Diff
Bump version to 3.0.0b6
mod - Version Diff File

master 395400ca

2016-01-21 14:59

Francis Lachapelle


Details Diff
(js/css) Update generated files
mod - UI/WebServerResources/css/styles.css Diff File
mod - UI/WebServerResources/css/styles.css.map Diff File

master 218aeb5f

2016-01-21 14:58

Francis Lachapelle


Details Diff
(css) Fix display of md-cards in .view-detail
mod - UI/WebServerResources/scss/views/MailerUI.scss Diff File
mod - UI/WebServerResources/scss/views/_view.scss Diff File

master 522dc5f8

2016-01-21 10:21

Francis Lachapelle


Details Diff
(js/css) Update generated files
mod - UI/WebServerResources/css/styles.css Diff File
mod - UI/WebServerResources/css/styles.css.map Diff File
mod - UI/WebServerResources/js/Administration.js Diff File
mod - UI/WebServerResources/js/Administration.js.map Diff File
mod - UI/WebServerResources/js/Common.js Diff File
mod - UI/WebServerResources/js/Common.js.map Diff File
mod - UI/WebServerResources/js/Contacts.js Diff File
mod - UI/WebServerResources/js/Contacts.js.map Diff File
mod - UI/WebServerResources/js/Contacts.services.js Diff File
mod - UI/WebServerResources/js/Contacts.services.js.map Diff File
mod - UI/WebServerResources/js/Mailer.js Diff File
mod - UI/WebServerResources/js/Mailer.js.map Diff File
mod - UI/WebServerResources/js/Mailer.services.js Diff File
mod - UI/WebServerResources/js/Mailer.services.js.map Diff File
mod - UI/WebServerResources/js/Scheduler.services.js Diff File
mod - UI/WebServerResources/js/Scheduler.services.js.map Diff File
mod - UI/WebServerResources/js/vendor/angular-animate.js Diff File
mod - UI/WebServerResources/js/vendor/angular-animate.min.js Diff File
mod - UI/WebServerResources/js/vendor/angular-animate.min.js.map Diff File
mod - UI/WebServerResources/js/vendor/angular-aria.js Diff File
mod - UI/WebServerResources/js/vendor/angular-aria.min.js Diff File
mod - UI/WebServerResources/js/vendor/angular-material.js Diff File
mod - UI/WebServerResources/js/vendor/angular-material.min.js Diff File
mod - UI/WebServerResources/js/vendor/angular-sanitize.js Diff File
mod - UI/WebServerResources/js/vendor/angular-sanitize.min.js Diff File
mod - UI/WebServerResources/js/vendor/angular.js Diff File
mod - UI/WebServerResources/js/vendor/angular.min.js Diff File
mod - UI/WebServerResources/js/vendor/angular.min.js.map Diff File
mod - UI/WebServerResources/js/vendor/lodash.js Diff File

master 8076a1a7

2016-01-21 10:17

Francis Lachapelle


Details Diff
Update translations
mod - SoObjects/Appointments/Catalan.lproj/Localizable.strings Diff File
mod - SoObjects/Appointments/Macedonian.lproj/Localizable.strings Diff File
mod - SoObjects/Appointments/Polish.lproj/Localizable.strings Diff File
mod - SoObjects/Appointments/Russian.lproj/Localizable.strings Diff File
mod - SoObjects/Appointments/SpanishArgentina.lproj/Localizable.strings Diff File
mod - SoObjects/Contacts/SpanishArgentina.lproj/Localizable.strings Diff File
mod - SoObjects/Mailer/SOGoMailRussianForward.wo/SOGoMailRussianForward.html Diff File
mod - SoObjects/Mailer/SOGoMailRussianReply.wo/SOGoMailRussianReply.html Diff File
mod - UI/AdministrationUI/BrazilianPortuguese.lproj/Localizable.strings Diff File
mod - UI/AdministrationUI/Catalan.lproj/Localizable.strings Diff File
mod - UI/AdministrationUI/Finnish.lproj/Localizable.strings Diff File
mod - UI/AdministrationUI/German.lproj/Localizable.strings Diff File
mod - UI/AdministrationUI/Hungarian.lproj/Localizable.strings Diff File
mod - UI/AdministrationUI/Macedonian.lproj/Localizable.strings Diff File
mod - UI/AdministrationUI/Polish.lproj/Localizable.strings Diff File
mod - UI/AdministrationUI/Russian.lproj/Localizable.strings Diff File
mod - UI/AdministrationUI/SpanishSpain.lproj/Localizable.strings Diff File
mod - UI/Common/BrazilianPortuguese.lproj/Localizable.strings Diff File
mod - UI/Common/Catalan.lproj/Localizable.strings Diff File
mod - UI/Common/English.lproj/Localizable.strings Diff File
mod - UI/Common/Finnish.lproj/Localizable.strings Diff File
mod - UI/Common/German.lproj/Localizable.strings Diff File
mod - UI/Common/Hungarian.lproj/Localizable.strings Diff File
mod - UI/Common/Macedonian.lproj/Localizable.strings Diff File
mod - UI/Common/Polish.lproj/Localizable.strings Diff File
mod - UI/Common/Russian.lproj/Localizable.strings Diff File
mod - UI/Common/SpanishArgentina.lproj/Localizable.strings Diff File
mod - UI/Common/SpanishSpain.lproj/Localizable.strings Diff File
mod - UI/Contacts/BrazilianPortuguese.lproj/Localizable.strings Diff File
mod - UI/Contacts/Catalan.lproj/Localizable.strings Diff File
mod - UI/Contacts/English.lproj/Localizable.strings Diff File
mod - UI/Contacts/Finnish.lproj/Localizable.strings Diff File
mod - UI/Contacts/French.lproj/Localizable.strings Diff File
mod - UI/Contacts/German.lproj/Localizable.strings Diff File
mod - UI/Contacts/Hungarian.lproj/Localizable.strings Diff File
mod - UI/Contacts/Macedonian.lproj/Localizable.strings Diff File
mod - UI/Contacts/Polish.lproj/Localizable.strings Diff File
mod - UI/Contacts/Russian.lproj/Localizable.strings Diff File
mod - UI/Contacts/SpanishArgentina.lproj/Localizable.strings Diff File
mod - UI/Contacts/SpanishSpain.lproj/Localizable.strings Diff File
mod - UI/MailPartViewers/BrazilianPortuguese.lproj/Localizable.strings Diff File
mod - UI/MailPartViewers/Catalan.lproj/Localizable.strings Diff File
mod - UI/MailPartViewers/Finnish.lproj/Localizable.strings Diff File
mod - UI/MailPartViewers/German.lproj/Localizable.strings Diff File
mod - UI/MailPartViewers/Hungarian.lproj/Localizable.strings Diff File
mod - UI/MailPartViewers/Macedonian.lproj/Localizable.strings Diff File
mod - UI/MailPartViewers/Polish.lproj/Localizable.strings Diff File
mod - UI/MailPartViewers/Russian.lproj/Localizable.strings Diff File
mod - UI/MailPartViewers/SpanishArgentina.lproj/Localizable.strings Diff File
mod - UI/MailPartViewers/SpanishSpain.lproj/Localizable.strings Diff File
mod - UI/MailerUI/BrazilianPortuguese.lproj/Localizable.strings Diff File
mod - UI/MailerUI/Catalan.lproj/Localizable.strings Diff File
mod - UI/MailerUI/English.lproj/Localizable.strings Diff File
mod - UI/MailerUI/Finnish.lproj/Localizable.strings Diff File
mod - UI/MailerUI/German.lproj/Localizable.strings Diff File
mod - UI/MailerUI/Hungarian.lproj/Localizable.strings Diff File
mod - UI/MailerUI/Macedonian.lproj/Localizable.strings Diff File
mod - UI/MailerUI/Polish.lproj/Localizable.strings Diff File
mod - UI/MailerUI/Russian.lproj/Localizable.strings Diff File
mod - UI/MailerUI/SpanishArgentina.lproj/Localizable.strings Diff File
mod - UI/MailerUI/SpanishSpain.lproj/Localizable.strings Diff File
mod - UI/MainUI/BrazilianPortuguese.lproj/Localizable.strings Diff File
mod - UI/MainUI/Catalan.lproj/Localizable.strings Diff File
mod - UI/MainUI/Finnish.lproj/Localizable.strings Diff File
mod - UI/MainUI/German.lproj/Localizable.strings Diff File
mod - UI/MainUI/Hungarian.lproj/Localizable.strings Diff File
mod - UI/MainUI/Macedonian.lproj/Localizable.strings Diff File
mod - UI/MainUI/Polish.lproj/Localizable.strings Diff File
mod - UI/MainUI/Russian.lproj/Localizable.strings Diff File
mod - UI/MainUI/SpanishArgentina.lproj/Localizable.strings Diff File
mod - UI/MainUI/SpanishSpain.lproj/Localizable.strings Diff File
mod - UI/PreferencesUI/BrazilianPortuguese.lproj/Localizable.strings Diff File
mod - UI/PreferencesUI/Catalan.lproj/Localizable.strings Diff File
mod - UI/PreferencesUI/Danish.lproj/Localizable.strings Diff File
mod - UI/PreferencesUI/English.lproj/Localizable.strings Diff File
mod - UI/PreferencesUI/Finnish.lproj/Localizable.strings Diff File
mod - UI/PreferencesUI/German.lproj/Localizable.strings Diff File
mod - UI/PreferencesUI/Hungarian.lproj/Localizable.strings Diff File
mod - UI/PreferencesUI/Macedonian.lproj/Localizable.strings Diff File
mod - UI/PreferencesUI/Polish.lproj/Localizable.strings Diff File
mod - UI/PreferencesUI/Russian.lproj/Localizable.strings Diff File
mod - UI/PreferencesUI/SpanishArgentina.lproj/Localizable.strings Diff File
mod - UI/PreferencesUI/SpanishSpain.lproj/Localizable.strings Diff File
mod - UI/Scheduler/BrazilianPortuguese.lproj/Localizable.strings Diff File
mod - UI/Scheduler/Catalan.lproj/Localizable.strings Diff File
mod - UI/Scheduler/English.lproj/Localizable.strings Diff File
mod - UI/Scheduler/Finnish.lproj/Localizable.strings Diff File
mod - UI/Scheduler/French.lproj/Localizable.strings Diff File
mod - UI/Scheduler/German.lproj/Localizable.strings Diff File
mod - UI/Scheduler/Hungarian.lproj/Localizable.strings Diff File
mod - UI/Scheduler/Macedonian.lproj/Localizable.strings Diff File
mod - UI/Scheduler/Polish.lproj/Localizable.strings Diff File
mod - UI/Scheduler/Russian.lproj/Localizable.strings Diff File
mod - UI/Scheduler/SpanishArgentina.lproj/Localizable.strings Diff File
mod - UI/Scheduler/SpanishSpain.lproj/Localizable.strings Diff File
mod - UI/Templates/SOGoACLRussianAdditionAdvisory.wox Diff File

v2 04c68e06

2016-01-21 10:10

francis


Details Diff
Localization
mod - UI/Contacts/French.lproj/Localizable.strings Diff File
mod - UI/Scheduler/Finnish.lproj/Localizable.strings Diff File
mod - UI/Scheduler/French.lproj/Localizable.strings Diff File
mod - UI/Scheduler/German.lproj/Localizable.strings Diff File
mod - UI/Scheduler/Polish.lproj/Localizable.strings Diff File
mod - UI/Scheduler/Russian.lproj/Localizable.strings Diff File
mod - UI/Scheduler/SpanishSpain.lproj/Localizable.strings Diff File

v2 bf7f5e8b

2016-01-20 15:09

francis


Details Diff
Localization
mod - UI/Scheduler/English.lproj/Localizable.strings Diff File

master 164f7fd7

2016-01-20 14:02

Francis Lachapelle


Details Diff
(html) Hide export/source options for remote ab
mod - UI/Templates/ContactsUI/UIxContactViewTemplate.wox Diff File

v2 f1d0f770

2016-01-20 13:59

francis


Details Diff
Revert "Request all contacts when no filter"

This reverts commit 1c8b693656bfb79445fce3c99a97534c228de163.
mod - UI/WebServerResources/ContactsUI.js Diff File

v2 1bae41e1

2016-01-20 05:02

Jesús García Sáez


Details Diff
Request all contacts no longer needs value=.

This reverts 1c8b693 and it's possible thanks to removing
listRequiresDot option 6b2ec7a

Listing contacts didn't work for sources with listRequiresDot
set to YES (LDAPSource, by default, had this option that way)
mod - UI/WebServerResources/ContactsUI.js Diff File
 First  Prev  1 2 3 ... 20 ... 40 ... 60 ... 80 ... 100 ... 120 ... 140 ... 160 ... 177 178 179 180 181 182 183 ... 200 ... 220 ... 226 227 228  Next  Last