Dependency Graph

View IssueRelationship GraphVerticalShow Summary
Dependency Graph
related to related to child of child of duplicate of duplicate of

View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000183SOGoWeb Calendarpublic2009-10-20 13:092009-10-20 19:51
Reporterklaasd Assigned Toludovic  
PrioritynormalSeveritymajorReproducibilityhave not tried
Status resolvedResolutionfixed 
PlatformLinux 
Target Version1.1.0Fixed in Version1.1.0 
Summary0000183: Inconsistency between web interface and lightning
Description

Hi,

at the moment, I have an inconsistency between date information shown in Thunderbird and the information in the web interface of SOGo. I've attached two screenshots which show my appointments for tomorrow. In the web interface, the appointments are shifted by one hour although in Thunderbird as well as on the server, I use Europe/Berlin as the time zone.

Oddly, only single appointments seem to be moved by one hour. If it is an reoccurring event (i.e. the "Standup Meeting"), Thunderbird as well as the web interface show the same and correct starting time.

The problem seems to be similar to bug 0000180. I applied the patch given in that bug report and restarted sogod, but it didn't fix the problem. Besides the screen shots, I also attach the corresponding table rows from the quick table and the normal user table with the information about the appointments.

TagsNo tags attached.

Relationships

Relationship GraphDependency Graph
duplicate of 0000180 resolvedludovic Adding event in Lightning shifted one hour in web interface 

Activities

2009-10-20 13:09

 

thunderbird.png (6,594 bytes)   
thunderbird.png (6,594 bytes)   

2009-10-20 13:09

 

Webinterface.png (14,820 bytes)   
Webinterface.png (14,820 bytes)   

2009-10-20 13:09

 

quick_table.csv (579 bytes)    
"ffd44468-0d7e-48a1-bffd-37373a220869.ics";"ffd44468-0d7e-48a1-bffd-37373a220869";1256119200;1256121900;;"Besprechung";"";0;0;"";0;1;1;0;"''";"''";"";"''";2;"vevent";1256118300
"a5ff36e6-1202-4b3c-92f3-4d367393081f.ics";"a5ff36e6-1202-4b3c-92f3-4d367393081f";1243417500;1243421100;2147483647;"Standup Meeting";"";0;1;"{rules = ("FREQ=WEEKLY;INTERVAL=1"); }";0;1;1;0;"''";"''";"";"''";0;"vevent";0
"19217498-5989-4637-8a8c-e161b1999d19.ics";"19217498-5989-4637-8a8c-e161b1999d19";1256126400;1256130000;;"Präsentation";"";0;0;"";0;1;1;0;"B132";"''";"";"''";0;"vevent";1256125500
quick_table.csv (579 bytes)   

2009-10-20 13:10

 

usertable.csv (2,975 bytes)    
"19217498-5989-4637-8a8c-e161b1999d19.ics";"BEGIN:VCALENDAR
PRODID:-//Mozilla.org/NONSGML Mozilla Calendar V1.1//EN
VERSION:2.0
BEGIN:VTIMEZONE
TZID:Europe/Berlin
X-LIC-LOCATION:Europe/Berlin
BEGIN:DAYLIGHT
TZOFFSETFROM:+0100
TZOFFSETTO:+0200
TZNAME:CEST
DTSTART:19700329T020000
RRULE:FREQ=YEARLY;INTERVAL=1;BYDAY=-1SU;BYMONTH=3
END:DAYLIGHT
BEGIN:STANDARD
TZOFFSETFROM:+0200
TZOFFSETTO:+0100
TZNAME:CET
DTSTART:19701025T030000
RRULE:FREQ=YEARLY;INTERVAL=1;BYDAY=-1SU;BYMONTH=10
END:STANDARD
END:VTIMEZONE
BEGIN:VEVENT
CREATED:20091016T111911Z
LAST-MODIFIED:20091020T123343Z
DTSTAMP:20091016T111933Z
UID:19217498-5989-4637-8a8c-e161b1999d19
SUMMARY:Präsentation
DTSTART;TZID=Europe/Berlin:20091021T130000
DTEND;TZID=Europe/Berlin:20091021T140000
LOCATION:B132
X-MOZ-GENERATION:1
BEGIN:VALARM
ACTION:DISPLAY
TRIGGER;VALUE=DURATION:-PT15M
END:VALARM
TRANSP:OPAQUE
END:VEVENT
END:VCALENDAR";1255692497;1256042023;1;
"a5ff36e6-1202-4b3c-92f3-4d367393081f.ics";"BEGIN:VCALENDAR
PRODID:-//Mozilla.org/NONSGML Mozilla Calendar V1.1//EN
VERSION:2.0
BEGIN:VTIMEZONE
TZID:Europe/Berlin
X-LIC-LOCATION:Europe/Berlin
BEGIN:DAYLIGHT
TZOFFSETFROM:+0100
TZOFFSETTO:+0200
TZNAME:CEST
DTSTART:19700329T020000
RRULE:FREQ=YEARLY;INTERVAL=1;BYDAY=-1SU;BYMONTH=3
END:DAYLIGHT
BEGIN:STANDARD
TZOFFSETFROM:+0200
TZOFFSETTO:+0100
TZNAME:CET
DTSTART:19701025T030000
RRULE:FREQ=YEARLY;INTERVAL=1;BYDAY=-1SU;BYMONTH=10
END:STANDARD
END:VTIMEZONE
BEGIN:VEVENT
CREATED:20090520T084650Z
LAST-MODIFIED:20091014T094130Z
DTSTAMP:20091014T094130Z
UID:a5ff36e6-1202-4b3c-92f3-4d367393081f
SUMMARY:Standup Meeting
RRULE:FREQ=WEEKLY;INTERVAL=1
X-MOZ-LASTACK:20091014T094130Z
DTSTART;TZID=Europe/Berlin:20090527T114500
DTEND;TZID=Europe/Berlin:20090527T124500
X-MOZ-LASTACK:20091007T201221Z
X-MOZ-GENERATION:2
TRANSP:OPAQUE
BEGIN:VALARM
TRIGGER;VALUE=DURATION:-PT5M
DESCRIPTION:Mozilla Alarm: Standup Meeting
ACTION:DISPLAY
END:VALARM
END:VEVENT
END:VCALENDAR
";1255101490;1255513810;1;
"ffd44468-0d7e-48a1-bffd-37373a220869.ics";"BEGIN:VCALENDAR
PRODID:-//Mozilla.org/NONSGML Mozilla Calendar V1.1//EN
VERSION:2.0
BEGIN:VTIMEZONE
TZID:Europe/Berlin
X-LIC-LOCATION:Europe/Berlin
BEGIN:DAYLIGHT
TZOFFSETFROM:+0100
TZOFFSETTO:+0200
TZNAME:CEST
DTSTART:19700329T020000
RRULE:FREQ=YEARLY;INTERVAL=1;BYDAY=-1SU;BYMONTH=3
END:DAYLIGHT
BEGIN:STANDARD
TZOFFSETFROM:+0200
TZOFFSETTO:+0100
TZNAME:CET
DTSTART:19701025T030000
RRULE:FREQ=YEARLY;INTERVAL=1;BYDAY=-1SU;BYMONTH=10
END:STANDARD
END:VTIMEZONE
BEGIN:VEVENT
CREATED:20091020T120356Z
LAST-MODIFIED:20091020T123236Z
DTSTAMP:20091020T120817Z
UID:ffd44468-0d7e-48a1-bffd-37373a220869
SUMMARY:Besprechung
DTSTART;TZID=Europe/Berlin:20091021T110000
DTEND;TZID=Europe/Berlin:20091021T114500
X-MOZ-GENERATION:2
SEQUENCE:1
BEGIN:VALARM
ACTION:DISPLAY
TRIGGER;VALUE=DURATION:-PT15M
END:VALARM
TRANSP:OPAQUE
END:VEVENT
END:VCALENDAR";1256040787;1256041956;2;
usertable.csv (2,975 bytes)   
ludovic

ludovic

2009-10-20 13:14

administrator   ~0000221

The patch in 0000180 won't fix existing events. Have you tried to recreate them?
klaasd

klaasd

2009-10-20 13:22

reporter   ~0000222

Not at the time of the bug report ;-) But now:

1) Modifying the existing appointments doesn't fix the problem.
2) Creating a new appointment at 11:00-11:45 in web interface appears correctly in web interface and thunderbird.
3) Creating a new appointment at 11:00-11:45 in thunderbird shows up incorrectly in web interface but correctly in thunderbird.
klaasd

klaasd

2009-10-20 13:38

reporter   ~0000223

I think an interesting observation of my bug report is that SOGo seems to use different parts of its source code for "rendering" an appointment in its web interface, depending on whether it is a recurring event ("Standup Meeting") or a single event ("Besprechung") and that the source code for rendering the recurring events seems to handle it correctly.

2009-10-20 15:55

 

dst1.diff (1,831 bytes)    
#
# old_revision [a7388b1eb7856d57df84b1de0be0ed020317178c]
#
# patch "SOPE/NGCards/iCalDateTime.h"
#  from [689fc54ca10227b4bc8ffacee0d893879d6ea8e8]
#    to [69fbe2f5f2e1bca0cee5676a41dea904b4d5c7f1]
# 
# patch "SOPE/NGCards/iCalTimeZonePeriod.m"
#  from [3d5a26016cde881cc168146ef554ba0c53654e5d]
#    to [f4735ea479184015397ffbdcb12f4305ed741414]
#
============================================================
--- SOPE/NGCards/iCalDateTime.h	689fc54ca10227b4bc8ffacee0d893879d6ea8e8
+++ SOPE/NGCards/iCalDateTime.h	69fbe2f5f2e1bca0cee5676a41dea904b4d5c7f1
@@ -1,6 +1,6 @@
 /* iCalDateTime.h - this file is part of SOGo
  *
- * Copyright (C) 2006 Inverse inc.
+ * Copyright (C) 2006-2009 Inverse inc.
  *
  * Author: Wolfgang Sourdeau <wsourdeau@inverse.ca>
  *
============================================================
--- SOPE/NGCards/iCalTimeZonePeriod.m	3d5a26016cde881cc168146ef554ba0c53654e5d
+++ SOPE/NGCards/iCalTimeZonePeriod.m	f4735ea479184015397ffbdcb12f4305ed741414
@@ -110,6 +110,7 @@
   dayOfWeek = [self dayOfWeekFromRruleDay: [rrule byDayMask]];
   pos = [[byDay substringToIndex: 2] intValue];
   if (!pos)
+    /* if byday = "SU", instead of "1SU"... */
     pos = 1;
 
   tmpDate = [NSCalendarDate dateWithYear: [refDate yearOfCommonEra]
@@ -119,9 +120,17 @@
   tmpDate = [tmpDate addYear: 0 month: ((pos > 0) ? 0 : 1)
 		     day: 0 hour: 0 minute: 0
 		     second: -[self _secondsOfOffset: @"tzoffsetfrom"]];
+
   dateDayOfWeek = [tmpDate dayOfWeek];
-// #warning FIXME
-  offset = (dayOfWeek - dateDayOfWeek) + ((pos -1 ) * 7);
+
+//   if (pos < 0)
+//     pos++;
+
+  if (pos > 0)
+    offset = (dayOfWeek - dateDayOfWeek) + ((pos - 1) * 7);
+  else
+    offset = (dateDayOfWeek - dayOfWeek) + (pos * 7);
+
   tmpDate = [tmpDate addYear: 0 month: 0 day: offset
 		     hour: 0 minute: 0 second: 0];
dst1.diff (1,831 bytes)   
ludovic

ludovic

2009-10-20 15:55

administrator   ~0000225

Try the patch I've just added.
klaasd

klaasd

2009-10-20 16:49

reporter   ~0000227

I can confirm that the patch fixed the problem.
ludovic

ludovic

2009-10-20 19:51

administrator   ~0000229

Fixed by http://mtn.inverse.ca/revision/diff/a7388b1eb7856d57df84b1de0be0ed020317178c/with/1cdbd08ce823952005537aad8577c0f54c23c532

Issue History

Date Modified Username Field Change
2009-10-20 13:09 klaasd New Issue
2009-10-20 13:09 klaasd File Added: thunderbird.png
2009-10-20 13:09 klaasd File Added: Webinterface.png
2009-10-20 13:09 klaasd File Added: quick_table.csv
2009-10-20 13:10 klaasd File Added: usertable.csv
2009-10-20 13:14 ludovic Note Added: 0000221
2009-10-20 13:22 klaasd Note Added: 0000222
2009-10-20 13:38 klaasd Note Added: 0000223
2009-10-20 14:55 ludovic OS Ubuntu =>
2009-10-20 14:55 ludovic OS Version 9.04 =>
2009-10-20 14:55 ludovic Target Version => 1.1.0
2009-10-20 15:55 ludovic File Added: dst1.diff
2009-10-20 15:55 ludovic Note Added: 0000225
2009-10-20 15:55 ludovic Relationship added duplicate of 0000180
2009-10-20 16:49 klaasd Note Added: 0000227
2009-10-20 19:51 ludovic Note Added: 0000229
2009-10-20 19:51 ludovic Status new => resolved
2009-10-20 19:51 ludovic Fixed in Version => 1.1.0
2009-10-20 19:51 ludovic Resolution open => fixed
2009-10-20 19:51 ludovic Assigned To => ludovic